Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AnalysisDamagesEnum to AnalysisEnum (and related items) #611

Open
ArdtK opened this issue Nov 27, 2024 · 1 comment
Open

Refactor AnalysisDamagesEnum to AnalysisEnum (and related items) #611

ArdtK opened this issue Nov 27, 2024 · 1 comment
Labels
architecture refactoring Architectural changes to be addressed by the GAP team
Milestone
Sprint 2024 Q4.4

Comments

@ArdtK
Copy link
Contributor

ArdtK commented Nov 27, 2024 •
edited
Loading

Currently ADAPTATION has been added to AnalysisDamagesEnum for practical reasons. This class should be renamed to AnalysisEnum as it now contains also DAMAGES.
No second damages or adaptation analysis is expected to be added in the future.

All places where damages is referenced as a list, should be refactored to a single analysis.
@ArdtK ArdtK added this to the Sprint 2024 Q4.4 milestone Nov 27, 2024
@ArdtK ArdtK mentioned this issue Dec 10, 2024
Merged
7 tasks
@Carsopre
Copy link
Collaborator

Please format the issue description with the corresponding template:
https://github.com/Deltares/ra2ce/blob/master/.github/ISSUE_TEMPLATE/feature_request.yaml

@Carsopre Carsopre added the architecture refactoring Architectural changes to be addressed by the GAP team label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture refactoring Architectural changes to be addressed by the GAP team
Projects
None yet
Milestone
Sprint 2024 Q4.4
Development

No branches or pull requests
2 participants
@Carsopre @ArdtK