Parameters Converter

[MAfarrag]

Parameter Quantity Converter

• Add old parameter quantities in the extold.ExtOldParametersQuantity
• Add converter for the parameter quantities in the main_converter to the

New Features

• The main_converter.py now can convert the boundary condition quantities.

Design

• Functions/method better have one return statement at the end of the function for readability (ext.models.Boundary.forcing).
• Test directory better be a mirror of the modules in the package directory.
• merge base_converter.py, converter_factory.py in converters.py.
• merge tools.ext_old_to_new.enum_converters.py to tools.ext_old_to_new.utils.
• the __contains__ function is now a method contains in the ConverterFactory class.

Formating and Styling

None

Testing

Data

None

New Tests

• tests/dflowfm/test_extold.py::test_ext_old_parameter_quantity
• tests\tools\test_converters.py::TestConvertParameters::test_sample_data_file
• tests\tools\test_converters.py::TestConvertMeteo::test_default

Old errors

• Multiple uses of mutable objects like lists [] as a default values was converted to Field(default_factory=list)

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud