New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'edit_head_line' method to D-Stability Waternet #46

Open

yida-tao wants to merge 9 commits into Deltares:master from yida-tao:edit_headline

+326 −87

Contributor

yida-tao commented Nov 12, 2022

No description provided.


          Update internal.py

5c9fb1e

Contributor

carloslubbers commented Nov 14, 2022

Thanks for your contribution, the added method looks good! Could you add a small test verifying it's behavior in the file tests/models/dstability/test_waternets.py? You can add it right below test_add_head_line in a similar style, assert'ing that your method correctly updates the head line properties

carloslubbers linked an issue

that may be closed by this pull request

edit headline #45

Open

carloslubbers changed the title ~~Update internal.py~~ Add 'edit_head_line' method to D-Stability Waternet

yida-tao and others added 8 commits

November 14, 2022 14:36


          edit_reference_line

d8bf24b


          Update test waternets with edit head & reference line

e7e2bde


          test waterlines with new structure

e5b0c37


          Update test_waternets.py

4bbdbd5


          code smells

aa093f1


          small changes

aa10285


          added methods from internal to dstabilitymodel

42ebd1f


          Update dstability_model.py

c4eed50

sonarqubecloud bot commented Nov 18, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet