Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Use isinstance() instead of type()

Co-authored-by: Vincent Barbaresi <[email protected]>
  • Loading branch information
Defenso-QTH and vbarbaresi authored Sep 20, 2024
1 parent 1997670 commit 700f5d6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/functional_tests/0019_list_snapshot_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def common_function(
jails_as_rows, full=False
):
for flag in SORTING_FLAGS:
if type(jail) is list:
if isinstance(jail, list):
command = ['snaplist', 'ALL', '-s', flag]
else:
command = ['snaplist', jail.name, '-s', flag]
Expand All @@ -48,7 +48,7 @@ def common_function(
command
)

if type(jail) is list:
if isinstance(jail, list):
jails = jail
orig_list = parse_rows_output(result.output, 'snapall')
verify_list = []
Expand Down

0 comments on commit 700f5d6

Please sign in to comment.