Feature/sg 1488 yolo nas r integration sample and transforms #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ygon-polygon iou for metric
…ygon-polygon iou for metric
# Conflicts: # src/super_gradients/training/utils/distributed_training_utils.py
…feature/SG-1448-OBB # Conflicts: # src/super_gradients/training/processing/__init__.py # src/super_gradients/training/processing/defaults.py # src/super_gradients/training/processing/processing.py
shaydeci
suggested changes
May 19, 2024
There was a problem hiding this comment.
Some short minor comments.
The use of keypoints for rotated boxes for the Albu support is awesome! Lets just add another use case for testing in the albumentations integration test like we have for the other tasks (tests/integration_tests/albumentations_test.py).
Also, pretty sure I found some problems with the rotate90 transform, so just to be safe it might be a good idea to have just one test that forward some ample through all of the newly added transforms.
src/super_gradients/training/transforms/obb/obb_random_rotate90.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/obb/obb_random_rotate90.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/transforms/obb/obb_random_rotate90.py
Outdated
Show resolved
Hide resolved
BloodAxe
merged commit 3013463
into
feature/SG-1488-YoloNAS-R-integration
3 of 4 checks passed
BloodAxe
deleted the
feature/SG-1488-YoloNAS-R-integration-sample-and-transforms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds OBBSample dataclass and transforms related to OBB sample.
Plus Albu support