Check discovered device has name attribute to prevent failure #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this PR be approved to fix the issue please, or has this project been abandoned? @Deadolus |
|
Hmm, last time I checked ha-beurer it would have needed a complete overhault to get it working with a new HomeAssistant API - is it working for you now? edit: I think #4 fixed the issue I had - merging yours as well. |
Ah ok. No it's not working unfortunately, it doesn't discover the device. It just asks for the Name and MAC address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If discovered devices do not have a name attribute .lower will fail with:
AttributeError: 'NoneType' object has no attribute 'lower'Fixes #8