Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose changes for file name + line number #48

Merged
merged 1 commit into from
Apr 30, 2014
Merged

Propose changes for file name + line number #48

merged 1 commit into from
Apr 30, 2014

Conversation

valtido
Copy link
Contributor

@valtido valtido commented Apr 30, 2014

I feel it is more accepted to use filename.ext:123 as this can easily be copied and pasted and use when looking up a file on sublime, chrome dev tools source files.

it will help us save a few seconds each time we need to find the specific page and line number to make changes or place break points..

I feel it is more accepted to use `filename.ext:123` as this can easily be copied and pasted and use when looking up a file on sublime, chrome dev tools source files.

it will help us save a few seconds each time we need to find the specific page and line number to make changes or place break points..
DataTables pushed a commit that referenced this pull request Apr 30, 2014
Propose changes for file name + line number
@DataTables DataTables merged commit f75a48f into DataTables:master Apr 30, 2014
@DataTables
Copy link
Collaborator

Nice change - thanks for suggesting this. I'll rebuild and deploy Visual Event shortly.

DataTables pushed a commit that referenced this pull request Apr 30, 2014
@valtido
Copy link
Contributor Author

valtido commented Apr 30, 2014

A bit careless of me with the quotes, works like a charm, if I knew you'd respond this quickly would have suggested it monkeys ago :)

@DataTables
Copy link
Collaborator

No problem. You caught me at a good time for it :-)

@valtido valtido deleted the patch-2 branch April 30, 2014 10:32
@valtido
Copy link
Contributor Author

valtido commented Apr 30, 2014

ok, just thought you may want to have a look at this... https://developer.chrome.com/extensions/devtools_panels it might be a cool idea, to create a new panel "Visual Events" maybe this could be the way forward to resolve or alternative to #43 .

@DataTables
Copy link
Collaborator

Actually Chrome already has an event listeners list (also shown in the screenshot in the document you linked to). So I'm not sure how useful it would be. I suppose it would help tell what library assigned the code and where it was attached...

@valtido
Copy link
Contributor Author

valtido commented Apr 30, 2014

Function defined in Inline script:31

I think I may have made a mistake there, inline script:31 doesn't mean much...
Thought you may want to have a look at it :)

@DataTables
Copy link
Collaborator

Yeah possibly not. I'll look at that when I get a chance.

@valtido valtido mentioned this pull request Apr 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants