Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename internal HtmLawed, reduce CS diff and upgrade it #32

Merged
merged 9 commits into from
Dec 21, 2023

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Dec 8, 2023

now the patching is easier and better documented

improve 7108caa for easier long term maintenance/upgrades

@mvorisek mvorisek marked this pull request as ready for review December 8, 2023 14:52
@mvorisek mvorisek changed the title Rename HtmLawed, reduce CS diff and upgrade it Rename internal HtmLawed, reduce CS diff and upgrade it Dec 8, 2023
@mvorisek mvorisek force-pushed the restore_htmlawed_format branch 2 times, most recently from 0ec3b60 to f0554a1 Compare December 12, 2023 12:12
@mvorisek
Copy link
Contributor Author

@AllanJard and this one please as well

effective changes:

ecb0f16...ccb3e67 - minor upgrade changes

a753f3c...18c3d78 - is the new/official config [1] fine or was the config patched historically for DataTable Editor?

[1] https://github.com/vanilla/htmlawed/blob/v2.2.15/src/Htmlawed.php#L14

@AllanJard
Copy link
Contributor

I'll need to test this one fully before pulling it in (the case change might impact the non-composer loader). Hopefully that will be within the next week. I think there was a small patch for the config to allow data attributes or something like that, but I'll check that as well.

Many thanks for this.

@AllanJard AllanJard merged commit 9ae253a into DataTables:master Dec 21, 2023
16 checks passed
@mvorisek mvorisek deleted the restore_htmlawed_format branch December 21, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants