Improve callable phpdocs #29
Conversation
|
Thank you - are you happy for this to be pulled in under the MIT license? Also, I'm not sure if you saw, but the phoDocumentor issue with spread operators has been fixed, so I'll get the docs updated for that soon. I'm fully focused on the work for DataTables 2 at the moment, but when that drops I'll circle back to the phpstan issues highlighted before. |
yes, for all controbutions to this repo
Great, feel free to ping me on this PR once the CI is green, I will then make it green too. I don't need to hurry with these changes. |
|
Thank you. Note to self - before merge, I need to check the |
This comment was marked as resolved.
This comment was marked as resolved.
mvorisek
force-pushed
the
improve_callable_phpdoc
branch
2 times, most recently
from
56206a2
to
ed734ce
Compare
mvorisek
force-pushed
the
improve_callable_phpdoc
branch
from
ed734ce
to
98fcad5
Compare
| @@ -2047,7 +2048,7 @@ private function _ssp_limit($query, $http) | |||
| private function _get_where($query) | |||
| { | |||
| for ($i = 0; $i < count($this->_where); ++$i) { | |||
| if (is_callable($this->_where[$i])) { | |||
| if ($this->_where[$i] instanceof \Closure) { | |||
There was a problem hiding this comment.
the reason is Query::where does support only \Closure, so no BC break, actually it is a bugfix, as callable looking array might be regular where
|
@AllanJard can this PR be merged? |
|
Yes, sorry - things very busy at the moment :). Thank you for this! |
No description provided.