Drop PHP 5.3 support

Merge pull request #18 from mvorisek/drop_php5_support

.github/workflows/test-unit.yml

@@ -9,11 +9,11 @@ jobs:
     name: Unit
     runs-on: ubuntu-latest
     container:
-      image: ${{ (matrix.php == '5.3' || matrix.php == '5.4' || matrix.php == '5.5' || matrix.php == '5.6' || matrix.php == '7.0' || matrix.php == '7.1' || matrix.php == '7.2' || matrix.php == '7.3') && 'php' || 'ghcr.io/mvorisek/image-php' }}:${{ matrix.php }}
+      image: ${{ (matrix.php == '5.4' || matrix.php == '5.5' || matrix.php == '5.6' || matrix.php == '7.0' || matrix.php == '7.1' || matrix.php == '7.2' || matrix.php == '7.3') && 'php' || 'ghcr.io/mvorisek/image-php' }}:${{ matrix.php }}
     strategy:
       fail-fast: false
       matrix:
-        php: ['5.3', '5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', 'latest']
+        php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', 'latest']
         type: ['Lint']
 #        php: ['7.4', '8.0', '8.1', 'latest']
 #        type: ['Phpunit']
@@ -27,7 +27,7 @@ jobs:
         uses: actions/checkout@v3
 
       - name: Configure PHP (for PHP < 7.4)
-        if: matrix.php == '5.3' || matrix.php == '5.4' || matrix.php == '5.5' || matrix.php == '5.6' || matrix.php == '7.0' || matrix.php == '7.1' || matrix.php == '7.2' || matrix.php == '7.3'
+        if: matrix.php == '5.4' || matrix.php == '5.5' || matrix.php == '5.6' || matrix.php == '7.0' || matrix.php == '7.1' || matrix.php == '7.2' || matrix.php == '7.3'
         run: |
           php --version
           echo 'deb [trusted=yes] http://archive.debian.org/debian jessie main' > /etc/apt/sources.list
@@ -39,7 +39,7 @@ jobs:
           sed -i 's/require-dev/require-xxx/g' composer.json
 
       - name: Configure PHP (for PHP >= 7.4)
-        if: matrix.php != '5.3' && matrix.php != '5.4' && matrix.php != '5.5' && matrix.php != '5.6' && matrix.php != '7.0' && matrix.php != '7.1' && matrix.php != '7.2' && matrix.php != '7.3'
+        if: matrix.php != '5.4' && matrix.php != '5.5' && matrix.php != '5.6' && matrix.php != '7.0' && matrix.php != '7.1' && matrix.php != '7.2' && matrix.php != '7.3'
         run: |
           rm /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini
           php --version

.php-cs-fixer.dist.php

@@ -1,43 +1,43 @@
 <?php
 
 $finder = PhpCsFixer\Finder::create()
-	->in(array(__DIR__))
+	->in([__DIR__])
 	->ignoreDotFiles(false)
 	->ignoreVCS(true)
-	->exclude(array('vendor', 'HtmLawed'));
+	->exclude(['vendor', 'HtmLawed']);
 
 $config = new PhpCsFixer\Config();
 
 return $config
 	->setRiskyAllowed(true)
 	->setIndent("\t")
-	->setRules(array(
+	->setRules([
 		'@PhpCsFixer' => true,
 		'@PhpCsFixer:risky' => true,
 		'@PHP74Migration' => true,
 		'@PHP74Migration:risky' => true,
 
 		// required by PSR-12
-		'concat_space' => array(
+		'concat_space' => [
 			'spacing' => 'one',
-		),
+		],
 
 		// disable some too strict rules
-		'phpdoc_types_order' => array(
+		'phpdoc_types_order' => [
 			'null_adjustment' => 'always_last',
 			'sort_algorithm' => 'none',
-		),
+		],
 		'single_line_throw' => false,
-		'yoda_style' => array(
+		'yoda_style' => [
 			'equal' => false,
 			'identical' => false,
-		),
+		],
 		'native_constant_invocation' => true,
 		'native_function_invocation' => false,
 		'void_return' => false,
-		'blank_line_before_statement' => array(
-			'statements' => array('break', 'continue', 'declare', 'return', 'throw', 'exit'),
-		),
+		'blank_line_before_statement' => [
+			'statements' => ['break', 'continue', 'declare', 'return', 'throw', 'exit'],
+		],
 		'combine_consecutive_issets' => false,
 		'combine_consecutive_unsets' => false,
 		'multiline_whitespace_before_semicolons' => false,
@@ -48,31 +48,28 @@
 		'phpdoc_add_missing_param_annotation' => false,
 		'return_assignment' => false,
 		'comment_to_phpdoc' => false,
-		'general_phpdoc_annotation_remove' => array(
-			'annotations' => array(/* 'author', 'copyright', */ 'throws'),
-		),
-		'nullable_type_declaration_for_default_null_value' => array(
+		'general_phpdoc_annotation_remove' => [
+			'annotations' => [/* 'author', 'copyright', */ 'throws'],
+		],
+		'nullable_type_declaration_for_default_null_value' => [
 			'use_nullable_type_declaration' => false,
-		),
+		],
 
 		// fn => without curly brackets is less readable,
 		// also prevent bounding of unwanted variables for GC
 		'use_arrow_functions' => false,
 
 		// disable too destructive formating for now
-		'list_syntax' => array('syntax' => 'long'), // needs PHP 5.4+
-		'array_syntax' => array('syntax' => 'long'), // needs PHP 5.4+
 		'ternary_to_null_coalescing' => false, // needs PHP 7.0+
 		'single_line_comment_style' => false,
 		'phpdoc_annotation_without_dot' => false,
 		'declare_strict_types' => false,
-		'static_lambda' => false, // needs PHP 5.4+
 		'strict_comparison' => false,
 		'strict_param' => false, // TODO
 		'final_internal_class' => false,
 		'function_to_constant' => false, // needs PHP 5.5+
 		'self_accessor' => false, // TODO some should be converted to static:: probably
-		'visibility_required' => array('elements' => array('property', 'method')), // needs PHP 7.1+
-	))
+		'visibility_required' => ['elements' => ['property', 'method']], // needs PHP 7.1+
+	])
 	->setFinder($finder)
 	->setCacheFile(sys_get_temp_dir() . '/php-cs-fixer.' . md5(__DIR__) . '.cache');

Bootstrap.php

@@ -2,7 +2,7 @@
 /**
  * DataTables PHP libraries.
  *
- * PHP libraries for DataTables and DataTables Editor, utilising PHP 5.3+.
+ * PHP libraries for DataTables and DataTables Editor.
  *
  *  @author    SpryMedia
  *  @copyright SpryMedia ( http://sprymedia.co.uk )

DataTables.php

@@ -2,7 +2,7 @@
 /**
  * DataTables PHP libraries.
  *
- * PHP libraries for DataTables and DataTables Editor, utilising PHP 5.3+.
+ * PHP libraries for DataTables and DataTables Editor.
  *
  *  @author    SpryMedia
  *  @copyright SpryMedia ( http://sprymedia.co.uk )
@@ -13,15 +13,15 @@
 define('DATATABLES', true);
 
 //
-// Error checking - check that we are PHP 5.3 or newer
+// Error checking - check that we are PHP 5.4 or newer
 //
-if (version_compare(\PHP_VERSION, '5.3.0', '<')) {
-	echo json_encode(array(
-		'sError' => 'Editor PHP libraries required PHP 5.3 or newer. You are ' .
-			'currently using ' . \PHP_VERSION . '. PHP 5.3 and newer have a lot of ' .
+if (version_compare(\PHP_VERSION, '5.4.0', '<')) {
+	echo json_encode([
+		'sError' => 'Editor PHP libraries required PHP 5.4 or newer. You are ' .
+			'currently using ' . \PHP_VERSION . '. PHP 5.4 and newer have a lot of ' .
 			'great new features that the Editor libraries take advantage of to ' .
 			'present an easy to use and flexible API.',
-	));
+	]);
 
 	exit(1);
 }

Database.php

@@ -2,7 +2,7 @@
 /**
  * DataTables PHP libraries.
  *
- * PHP libraries for DataTables and DataTables Editor, utilising PHP 5.3+.
+ * PHP libraries for DataTables and DataTables Editor.
  *
  *  @author    SpryMedia
  *  @copyright 2012 SpryMedia ( http://sprymedia.co.uk )
@@ -38,19 +38,19 @@ class Database
 	 *
 	 * @param array<string, string|\PDO> $opts Array of connection parameters for the database:
 	 *                                         ```php
-	 *                                         array(
+	 *                                         [
 	 *                                         "user" => "", // User name
 	 *                                         "pass" => "", // Password
 	 *                                         "host" => "", // Host name
 	 *                                         "port" => "", // Port
 	 *                                         "db"   => "", // Database name
 	 *                                         "type" => ""  // Datable type: "Mysql", "Postgres" or "Sqlite"
-	 *                                         )
+	 *                                         ]
 	 *                                         ```
 	 */
 	public function __construct($opts)
 	{
-		$types = array('Mysql', 'Oracle', 'Postgres', 'Sqlite', 'Sqlserver', 'Db2', 'Firebird');
+		$types = ['Mysql', 'Oracle', 'Postgres', 'Sqlite', 'Sqlserver', 'Db2', 'Firebird'];
 
 		if (!in_array($opts['type'], $types)) {
 			throw new \Exception(
@@ -466,10 +466,10 @@ public function debugInfo($query = null, $bindings = null)
 		$callback = $this->_debugCallback;
 
 		if ($callback) {
-			$callback(array(
+			$callback([
 				'query' => $query,
 				'bindings' => $bindings,
-			));
+			]);
 		}
 
 		return $this;

Database/Driver/Db2Query.php

@@ -58,10 +58,10 @@ public static function connect($user, $pass = '', $host = '', $port = '', $db =
 			// error.
 			$e = 'Connection failed: ' . db2_conn_error() . ' : ' . db2_conn_errormsg();
 
-			echo json_encode(array(
+			echo json_encode([
 				'error' => 'An error occurred while connecting to the database ' .
 					"'{$db}'. The error reported by the server was: " . $e,
-			));
+			]);
 
 			exit(1);
 		}
@@ -142,7 +142,7 @@ protected function _exec()
 
 	protected function _build_table()
 	{
-		$out = array();
+		$out = [];
 
 		for ($i = 0, $ien = count($this->_table); $i < $ien; ++$i) {
 			$t = $this->_table[$i];

Database/Driver/Db2Result.php

@@ -69,7 +69,7 @@ public function insertId()
 
 	private function _fetchAll()
 	{
-		$a = array();
+		$a = [];
 		while ($row = db2_fetch_assoc($this->_stmt)) {
 			$a[] = $row;
 		}

Database/Driver/FirebirdQuery.php

@@ -2,7 +2,7 @@
 /**
  * DataTables PHP libraries.
  *
- * PHP libraries for DataTables and DataTables Editor, utilising PHP 5.3+.
+ * PHP libraries for DataTables and DataTables Editor.
  *
  *  @author    SpryMedia
  *  @copyright 2012 SpryMedia ( http://sprymedia.co.uk )
@@ -27,7 +27,7 @@ class FirebirdQuery extends Query
 	 */
 	private $_stmt;
 
-	protected $_identifier_limiter = array('"', '"');
+	protected $_identifier_limiter = ['"', '"'];
 
 	protected $_field_quote = '"';
 
@@ -49,7 +49,7 @@ public static function connect($user, $pass = '', $host = '', $port = '', $db =
 			$host = $opts['host'];
 			$db = $opts['db'];
 			$dsn = isset($opts['dsn']) ? $opts['dsn'] : '';
-			$pdoAttr = isset($opts['pdoAttr']) ? $opts['pdoAttr'] : array();
+			$pdoAttr = isset($opts['pdoAttr']) ? $opts['pdoAttr'] : [];
 		}
 
 		if ($host !== '') {
@@ -74,10 +74,10 @@ public static function connect($user, $pass = '', $host = '', $port = '', $db =
 		} catch (\PDOException $e) {
 			// If we can't establish a DB connection then we return a DataTables
 			// error.
-			echo json_encode(array(
+			echo json_encode([
 				'error' => 'An error occurred while connecting to the database ' .
 					"'{$db}'. The error reported by the server was: " . $e->getMessage(),
-			));
+			]);
 
 			exit(1);
 		}

Database/Driver/FirebirdResult.php

@@ -2,7 +2,7 @@
 /**
  * DataTables PHP libraries.
  *
- * PHP libraries for DataTables and DataTables Editor, utilising PHP 5.3+.
+ * PHP libraries for DataTables and DataTables Editor.
  *
  *  @author    SpryMedia
  *  @copyright 2012 SpryMedia ( http://sprymedia.co.uk )

Database/Driver/MysqlQuery.php

@@ -2,7 +2,7 @@
 /**
  * DataTables PHP libraries.
  *
- * PHP libraries for DataTables and DataTables Editor, utilising PHP 5.3+.
+ * PHP libraries for DataTables and DataTables Editor.
  *
  *  @author    SpryMedia
  *  @copyright 2012 SpryMedia ( http://sprymedia.co.uk )
@@ -41,7 +41,7 @@ public static function connect($user, $pass = '', $host = '', $port = '', $db =
 			$db = $opts['db'];
 			$port = isset($opts['port']) ? $opts['port'] : '';
 			$dsn = isset($opts['dsn']) ? $opts['dsn'] : '';
-			$pdoAttr = isset($opts['pdoAttr']) ? $opts['pdoAttr'] : array();
+			$pdoAttr = isset($opts['pdoAttr']) ? $opts['pdoAttr'] : [];
 		}
 
 		if ($port !== '') {
@@ -60,10 +60,10 @@ public static function connect($user, $pass = '', $host = '', $port = '', $db =
 		} catch (\PDOException $e) {
 			// If we can't establish a DB connection then we return a DataTables
 			// error.
-			echo json_encode(array(
+			echo json_encode([
 				'error' => 'An error occurred while connecting to the database ' .
 					"'{$db}'. The error reported by the server was: " . $e->getMessage(),
-			));
+			]);
 
 			exit(1);
 		}

Database/Driver/MysqlResult.php

@@ -2,7 +2,7 @@
 /**
  * DataTables PHP libraries.
  *
- * PHP libraries for DataTables and DataTables Editor, utilising PHP 5.3+.
+ * PHP libraries for DataTables and DataTables Editor.
  *
  *  @author    SpryMedia
  *  @copyright 2012 SpryMedia ( http://sprymedia.co.uk )

Database/Driver/OracleQuery.php

@@ -30,7 +30,7 @@ class OracleQuery extends Query
 
 	private $_editor_pkey_value;
 
-	protected $_identifier_limiter = array('"', '"');
+	protected $_identifier_limiter = ['"', '"'];
 
 	protected $_field_quote = '"';
 
@@ -57,9 +57,9 @@ public static function connect($user, $pass = '', $host = '', $port = '', $db =
 		}
 
 		if (!function_exists('oci_connect')) {
-			echo json_encode(array(
+			echo json_encode([
 				'error' => 'oci methods are not available in this PHP install to connect to Oracle',
-			));
+			]);
 
 			exit(1);
 		}
@@ -71,10 +71,10 @@ public static function connect($user, $pass = '', $host = '', $port = '', $db =
 			// error.
 			$e = oci_error();
 
-			echo json_encode(array(
+			echo json_encode([
 				'error' => 'An error occurred while connecting to the database ' .
 					"'{$db}'. The error reported by the server was: " . $e['message'],
-			));
+			]);
 
 			exit(1);
 		}
@@ -166,7 +166,7 @@ protected function _exec()
 
 	protected function _build_table()
 	{
-		$out = array();
+		$out = [];
 
 		for ($i = 0, $ien = count($this->_table); $i < $ien; ++$i) {
 			$t = $this->_table[$i];

Database/Driver/OracleResult.php

@@ -57,7 +57,7 @@ public function fetch($fetchType = \PDO::FETCH_ASSOC /* irrelevant for oci8 */)
 	public function fetchAll($fetchType = \PDO::FETCH_ASSOC /* irrelevant for oci8 */)
 	{
 		if (!$this->_rows) {
-			$out = array();
+			$out = [];
 
 			oci_fetch_all($this->_stmt, $out, 0, -1, OCI_FETCHSTATEMENT_BY_ROW + OCI_ASSOC);