1d5373e1276fa1ffe755d054027ca3acfb23f0e5 Fix: Using a <span> in `-i…

…nit language.lengthMenu` could result in duplication of the page length `<select>` tag.

DD-2981
https://datatables.net/forums/discussion/79286

Sync to source repo @1d5373e1276fa1ffe755d054027ca3acfb23f0e5

datatables.json

@@ -11,5 +11,5 @@
     ],
     "src-repo": "http://github.com/DataTables/DataTablesSrc",
     "last-tag": "2.0.8",
-    "last-sync": "a8e62f88683146e4bad8b9550c85c772795a007a"
+    "last-sync": "1d5373e1276fa1ffe755d054027ca3acfb23f0e5"
 }

js/dataTables.js

@@ -13391,10 +13391,11 @@
 		}
 
 		// Wrapper element - use a span as a holder for where the select will go
+		var tmpId = 'tmp-' + (+new Date())
 		var div = $('<div/>')
 			.addClass( classes.container )
 			.append(
-				str.replace( '_MENU_', '<span></span>' )
+				str.replace( '_MENU_', '<span id="'+tmpId+'"></span>' )
 			);
 
 		// Save text node content for macro updating
@@ -13437,7 +13438,7 @@
 		__lengthCounter++;
 
 		// Swap in the select list
-		div.find('span').replaceWith(select);
+		div.find('#' + tmpId).replaceWith(select);
 
 		// Can't use `select` variable as user might provide their own and the
 		// reference is broken by the use of outerHTML

js/dataTables.mjs

@@ -13338,10 +13338,11 @@ DataTable.feature.register( 'pageLength', function ( settings, opts ) {
 	}
 
 	// Wrapper element - use a span as a holder for where the select will go
+	var tmpId = 'tmp-' + (+new Date())
 	var div = $('<div/>')
 		.addClass( classes.container )
 		.append(
-			str.replace( '_MENU_', '<span></span>' )
+			str.replace( '_MENU_', '<span id="'+tmpId+'"></span>' )
 		);
 
 	// Save text node content for macro updating
@@ -13384,7 +13385,7 @@ DataTable.feature.register( 'pageLength', function ( settings, opts ) {
 	__lengthCounter++;
 
 	// Swap in the select list
-	div.find('span').replaceWith(select);
+	div.find('#' + tmpId).replaceWith(select);
 
 	// Can't use `select` variable as user might provide their own and the
 	// reference is broken by the use of outerHTML