Skip to content

Commit

Permalink
1c48c11ac0168d9598795641b4fc337a2233289e Fix: Don't modify the displa…
Browse files Browse the repository at this point in the history
…y array in `-api row().remove()` - it should wait for the next draw

This relates to DataTables/DataTablesSrc#269
and is fairly nuanced - it boils down to the fact that the display array
should reflect what is shown in the table, and deleting a value from it
will cause an index offset. The other option might be to make the
element null, as happens with the master, but that would be a change in
type and I'm not certain everything could handle that. The array will
regenerate on the next draw, so it is properly in sync with what is
drawn now.

Sync to source repo @1c48c11ac0168d9598795641b4fc337a2233289e
  • Loading branch information
dtbuild committed Apr 18, 2024
1 parent 3f9b2b5 commit eff85c7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion datatables.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@
],
"src-repo": "http://github.com/DataTables/DataTablesSrc",
"last-tag": "2.0.4",
"last-sync": "d04853a9ab4fb7e9f5b4acfc1fea81f5952116e8"
"last-sync": "1c48c11ac0168d9598795641b4fc337a2233289e"
}

0 comments on commit eff85c7

Please sign in to comment.