-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][dinky-geteway] Feature Obtain job information using the ingress address #3871 #3887
Conversation
The configuration of the ingress address should follow the cluster configuration of k8s. |
I don't think it is necessary to bind to the K8s cluster, because in actual use, you can use the same ingress domain address even if you use multiple clusters |
Is there a situation where multiple clusters use different addresses? I think we can first implement the situation you mentioned, and then consider the situation I mentioned later. Thank you very much for your contribution. |
Thank you for your contribution!! |
dinky-gateway/src/main/java/org/dinky/gateway/kubernetes/KubernetesApplicationGateway.java
Outdated
Show resolved
Hide resolved
First of all, thank you for your reply. I think your suggestion is correct. I will modify the code according to your suggestion, verify it, and submit the code again |
...ter/Cluster/Configuration/components/ConfigurationModal/ConfigurationForm/FlinkK8s/index.tsx
Outdated
Show resolved
Hide resolved
dinky-web/src/pages/SettingCenter/GlobalSetting/SettingOverView/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ress address DataLinkDC#3871 (DataLinkDC#3887) Co-authored-by: jianjun.xu <[email protected]>
Purpose of the pull request
Feature Obtain job information using the ingress address
Brief change log
dinky-getaway moudle add ingress support
Be related to issues #3873
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: