Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][dinky-geteway] Feature Obtain job information using the ingress address #3871 #3887

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

jianjun159
Copy link
Contributor

@jianjun159 jianjun159 commented Oct 22, 2024

Purpose of the pull request

Feature Obtain job information using the ingress address
image

Brief change log

dinky-getaway moudle add ingress support
Be related to issues #3873

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@aiwenmo
Copy link
Contributor

aiwenmo commented Oct 22, 2024

The configuration of the ingress address should follow the cluster configuration of k8s.

@jianjun159
Copy link
Contributor Author

ingress地址的配置需要遵循k8s的集群配置。

I don't think it is necessary to bind to the K8s cluster, because in actual use, you can use the same ingress domain address even if you use multiple clusters

@aiwenmo
Copy link
Contributor

aiwenmo commented Oct 23, 2024

Is there a situation where multiple clusters use different addresses? I think we can first implement the situation you mentioned, and then consider the situation I mentioned later. Thank you very much for your contribution.

@Zzm0809
Copy link
Contributor

Zzm0809 commented Oct 23, 2024

Thank you for your contribution!!
It is recommended to add this configuration in cluster configuration when selecting k8s related mode. This configuration should be 1v1 compared to the cluster configuration!

@jianjun159
Copy link
Contributor Author

Thank you for your contribution!! It is recommended to add this configuration in cluster configuration when selecting k8s related mode. This configuration should be 1v1 compared to the cluster configuration!

First of all, thank you for your reply. I think your suggestion is correct. I will modify the code according to your suggestion, verify it, and submit the code again

@jianjun159
Copy link
Contributor Author

Thank you for your contribution!! It is recommended to add this configuration in cluster configuration when selecting k8s related mode. This configuration should be 1v1 compared to the cluster configuration!

企业微信截图_cdb822b7-643b-40a7-9a22-aed7385aaade
It is currently bound to the cluster

@jianjun159
Copy link
Contributor Author

@aiwenmo @Zzm0809 Hello Dear, Follow up your proposal, now it is modified to bind with the cluster, and I have submitted the relevant front and back end code, I hope you two bosses can help review it, thank you

@jianjun159 jianjun159 changed the title [Feature][dinky-geteway] Feature Obtain job information using the ingress address [Feature][dinky-geteway] Feature Obtain job information using the ingress address #3871 Oct 24, 2024
@Zzm0809 Zzm0809 added this to the 1.2.0 milestone Oct 28, 2024
@Zzm0809 Zzm0809 added the New Feature New feature label Oct 28, 2024
@Zzm0809 Zzm0809 self-requested a review October 28, 2024 00:56
Copy link
Contributor

@Zzm0809 Zzm0809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zzm0809 Zzm0809 merged commit f66e535 into DataLinkDC:dev Oct 28, 2024
17 checks passed
chenhaipeng pushed a commit to chenhaipeng/dinky that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants