[Feature] Sso Backend support #3366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aiwenmo,
gaoyan1998,
zackyoungh and
Zzm0809
Zzm0809
reviewed
Apr 9, 2024
| url: jdbc:mysql://${MYSQL_ADDR:127.0.0.1:3306}/${MYSQL_DATABASE:dinky}?useUnicode=true&characterEncoding=UTF-8&autoReconnect=true&useSSL=false&zeroDateTimeBehavior=convertToNull&serverTimezone=Asia/Shanghai&allowPublicKeyRetrieval=true | ||
| username: ${MYSQL_USERNAME:dinky} | ||
| password: ${MYSQL_PASSWORD:dinky} | ||
| url: jdbc:mysql://${MYSQL_ADDR:127.0.0.1:3306}/${MYSQL_DATABASE:dinky2}?useUnicode=true&characterEncoding=UTF-8&autoReconnect=true&useSSL=false&zeroDateTimeBehavior=convertToNull&serverTimezone=Asia/Shanghai&allowPublicKeyRetrieval=true |
…and get it from the configuration instead
Zzm0809
reviewed
Apr 16, 2024
dinky-admin/src/main/java/org/dinky/controller/SsoCpntroller.java
Outdated
Show resolved
Hide resolved
Zzm0809
reviewed
Apr 16, 2024
| @@ -16,7 +16,7 @@ spring: | |||
| # If you use pgsql database, please configure pgsql database connection information in application-pgsql.yml | |||
| # If you use the h2 database, please configure the h2 database connection information in application-h2.yml, | |||
| # note: the h2 database is only for experience use, and the related data that has been created cannot be migrated, please use it with caution | |||
| active: ${DB_ACTIVE:h2} #[h2,mysql,pgsql] | |||
| active: ${DB_ACTIVE:mysql} #[h2,mysql,pgsql] | |||
Zzm0809
reviewed
Apr 16, 2024
Zzm0809
reviewed
Apr 16, 2024
… interfaces after logging out.
Zzm0809
reviewed
May 7, 2024
dinky-admin/src/main/java/org/dinky/controller/SsoCpntroller.java
Outdated
Show resolved
Hide resolved
# Conflicts: # dinky-common/src/main/java/org/dinky/data/enums/Status.java
Signed-off-by: Zzm0809 <[email protected]>
|
controller 逻辑下沉到 service 层, 配置封装一下配置类,而不是通过@value 获取 |
|
@yangzehan 需要写一下文档 集成步骤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate github's oauth authentication.Other SSO authentication can be expanded in the future.
Users need to enable the sso function in the configuration
and configure the correct authentication parameters
Access the /sso/token port to log in.