Feat solid split n #3098
Merged
Feat solid split n #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lichao <[email protected]>
github-actions
bot
requested review from
aiwenmo,
gaoyan1998,
zackyoungh and
Zzm0809
aiwenmo
reviewed
Feb 16, 2024
Comment on lines
34
to
36
| private static final String SEMICOLON = ";"; | ||
| private static final String SQL_SEPARATOR = ";\\s*(?:\\n|--.*)"; | ||
|
|
There was a problem hiding this comment.
private final Configuration sqlSeparator = key(Status.SYS_FLINK_SETTINGS_SQLSEPARATOR)
.stringType()
.defaultValue(";\n")
.note(Status.SYS_FLINK_SETTINGS_SQLSEPARATOR_NOTE);
yangzehan
pushed a commit
to yangzehan/dinky
that referenced
this pull request
Feb 21, 2024
Signed-off-by: Lichao <[email protected]> Co-authored-by: leechor <[email protected]>
gaoyan1998
pushed a commit
to gaoyan1998/dinky
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Lichao <[email protected]> Co-authored-by: leechor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.