Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with newest arginfo gen_stub from PHP 8.4 #2973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Nov 21, 2024

Make sure things still work :-)

@bwoebi bwoebi requested a review from a team as a code owner November 21, 2024 12:20
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (35d1665) to head (a510bd2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2973   +/-   ##
=========================================
  Coverage     74.82%   74.82%           
  Complexity     2741     2741           
=========================================
  Files           110      110           
  Lines         10863    10863           
=========================================
  Hits           8128     8128           
  Misses         2735     2735           
Flag Coverage Δ
tracer-php 74.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d1665...a510bd2. Read the comment docs.

---- 🚨 Try these New Features:

@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-21 12:48:11

Comparing candidate commit a510bd2 in PR branch bob/update-arginfo with baseline commit 35d1665 in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+10.551µs; +14.782µs] or [+5.968%; +8.361%]

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟥 execution_time [+4.127µs; +11.825µs] or [+2.261%; +6.479%]

scenario:TraceFlushBench/benchFlushTrace

  • 🟩 execution_time [-1000.000ns; -1000.000ns] or [-50.000%; -50.000%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants