Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add the amqp extension to the buster images #2970

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented Nov 21, 2024

Description

Adds the AMQP extension and its dependency in preparation of some future, upcoming work related to #2324

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Nov 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.80%. Comparing base (ab52de5) to head (058aa74).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2970      +/-   ##
============================================
- Coverage     74.82%   74.80%   -0.02%     
  Complexity     2741     2741              
============================================
  Files           110      110              
  Lines         10863    10863              
============================================
- Hits           8128     8126       -2     
- Misses         2735     2737       +2     
Flag Coverage Δ
tracer-php 74.80% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab52de5...058aa74. Read the comment docs.

---- 🚨 Try these New Features:

@PROFeNoM PROFeNoM marked this pull request as ready for review November 21, 2024 11:25
@PROFeNoM PROFeNoM requested a review from a team as a code owner November 21, 2024 11:25
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me :-)

@PROFeNoM PROFeNoM merged commit 35d1665 into master Nov 21, 2024
643 of 676 checks passed
@PROFeNoM PROFeNoM deleted the alex/chore/amqp branch November 21, 2024 11:36
@github-actions github-actions bot added this to the 1.6.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants