Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge] Testing version. #2677

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

[Don't merge] Testing version. #2677

wants to merge 21 commits into from

Conversation

hoolioh
Copy link
Contributor

@hoolioh hoolioh commented May 28, 2024

  • Enable debug.
  • Enable sidecar sender.
  • Set fake version.

@pr-commenter
Copy link

pr-commenter bot commented May 28, 2024

Benchmarks

Benchmark execution time: 2024-06-19 13:06:57

Comparing candidate commit 1084168 in PR branch julio/testing with baseline commit 8d07c87 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 178 metrics, 0 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.75%. Comparing base (8d07c87) to head (b0a5599).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2677       +/-   ##
=============================================
- Coverage     77.96%   66.75%   -11.21%     
  Complexity     2212     2212               
=============================================
  Files           227      201       -26     
  Lines         26560    22549     -4011     
  Branches        988        0      -988     
=============================================
- Hits          20707    15053     -5654     
- Misses         5327     7496     +2169     
+ Partials        526        0      -526     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.44% <0.00%> (-0.41%) ⬇️
tracer-php 49.77% <ø> (-30.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ext/configuration.h 100.00% <ø> (ø)
ext/ddtrace.h 62.50% <ø> (ø)
ext/ddtrace.c 73.74% <0.00%> (-0.63%) ⬇️

... and 51 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d07c87...b0a5599. Read the comment docs.

@hoolioh hoolioh force-pushed the julio/testing branch 8 times, most recently from 87b8c3e to 89e9356 Compare June 3, 2024 12:56
@hoolioh hoolioh closed this Jun 4, 2024
@hoolioh hoolioh reopened this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants