Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Draft implementation for http.route in laminas #2394

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[DO NOT MERGE] Draft implementation for http.route in laminas #2394

wants to merge 1 commit into from

Conversation

pablomartinezbernardo
Copy link
Contributor

Description

Draft implementation of http.route in Laminas to show the possible approach and potential risks

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@github-actions GitHub Actions
Copy link

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

1 occurrences of :

- "parent_id": 2883696377808074518
+ "parent_id": 15784643431827456268

1 occurrences of :

- "laminas.route.name": "simple"
+ "_dd.p.tid": "65645caa00000000"

1 occurrences of :

- "name": "laminas.mvcEventListener"
+ "laminas.route.name": "simple"
+ "runtime-id": "05e49e0a-5ce8-4a67-9151-78ffaf427ea6"
+ "name": "laminas.route.match"

4 occurrences of :

- "resource": "Laminas\\Mvc\\RouteListener@onRoute"
+ "resource": "Laminas\\Mvc\\RouteListener@match"

1 occurrences of :

- {
- "name": "laminas.route.match"
- "service": "test_laminas_20"
- "resource": "Laminas\\Router\\Http\\TreeRouteStack@match"
- "trace_id": 0
- "span_id": 17
- "parent_id": 12
- "type": "web"
- "meta": {
- "component": "laminas"
- }
- }
- "span_id": 18
+ "span_id": 17

1 occurrences of :

- "span_id": 19
- "parent_id": 18
+ "span_id": 18
+ "parent_id": 17

1 occurrences of :

- "span_id": 20
- "parent_id": 19
+ "span_id": 19
+ "parent_id": 18

1 occurrences of :

- "parent_id": 2747341357639439789
+ "parent_id": 18444003753463499472

1 occurrences of :

- "name": "laminas.mvcEventListener"
+ "_dd.p.tid": "656460f800000000"
+ "runtime-id": "55b00f79-3f44-47f4-87d4-5b131249c8cd"
+ "name": "laminas.route.match"

1 occurrences of :

- {
- "name": "laminas.route.match"
- "service": "test_laminas_20"
- "resource": "Laminas\\Router\\Http\\TreeRouteStack@match"
- "trace_id": 0
- "span_id": 15
- "parent_id": 11
- "type": "web"
- "meta": {
- "component": "laminas"
- }
- }
- "span_id": 16
+ "span_id": 15

1 occurrences of :

- "span_id": 17
+ "span_id": 16

1 occurrences of :

- "span_id": 18
+ "span_id": 17

1 occurrences of :

- "span_id": 19
+ "span_id": 18

2 occurrences of :

- "span_id": 20
+ "span_id": 19

3 occurrences of :

- "span_id": 21
+ "span_id": 20

1 occurrences of :

- "span_id": 23
- "parent_id": 21
+ "span_id": 22
+ "parent_id": 20

1 occurrences of :

- "span_id": 24
- "parent_id": 23
+ "span_id": 23
+ "parent_id": 22

1 occurrences of :

- "span_id": 25
- "parent_id": 23
+ "span_id": 24
+ "parent_id": 22

3 occurrences of :

- "span_id": 22
+ "span_id": 21

1 occurrences of :

- "parent_id": 9335450213440539677
+ "parent_id": 5367084077876491877

1 occurrences of :

- "error.stack": "#0 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/Controller/AbstractActionController.php(72): Application\\Controller\\CommonSpecsController->errorAction()\n#1 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(320): Laminas\\Mvc\\Controller\\AbstractActionController->onDispatch(Object(Laminas\\Mvc\\MvcEvent))\n#2 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(178): Laminas\\EventManager\\EventManager->triggerListeners(Object(Laminas\\Mvc\\MvcEvent), Object(Closure))\n#3 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/Controller/AbstractController.php(105): Laminas\\EventManager\\EventManager->triggerEventUntil(Object(Closure), Object(Laminas\\Mvc\\MvcEvent))\n#4 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/DispatchListener.php(117): Laminas\\Mvc\\Controller\\AbstractController->dispatch(Object(Laminas\\Http\\PhpEnvironment\\Request), Object(Laminas\\Http\\PhpEnvironment\\Response))\n#5 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(320): Laminas\\Mvc\\DispatchListener->onDispatch(Object(Laminas\\Mvc\\MvcEvent))\n#6 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(178): Laminas\\EventManager\\EventManager->triggerListeners(Object(Laminas\\Mvc\\MvcEvent), Object(Closure))\n#7 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/Application.php(319): Laminas\\EventManager\\EventManager->triggerEventUntil(Object(Closure), Object(Laminas\\Mvc\\MvcEvent))\n#8 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/public/index.php(37): Laminas\\Mvc\\Application->run()\n#9 {main}"
+ "_dd.p.tid": "6564605400000000"
+ "error.stack": "#0 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/Controller/AbstractActionController.php(72): Application\\Controller\\CommonSpecsController->errorAction()\n#1 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(320): Laminas\\Mvc\\Controller\\AbstractActionController->onDispatch(Object(Laminas\\Mvc\\MvcEvent))\n#2 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(178): Laminas\\EventManager\\EventManager->triggerListeners(Object(Laminas\\Mvc\\MvcEvent), Object(Closure))\n#3 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/Controller/AbstractController.php(105): Laminas\\EventManager\\EventManager->triggerEventUntil(Object(Closure), Object(Laminas\\Mvc\\MvcEvent))\n#4 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/DispatchListener.php(117): Laminas\\Mvc\\Controller\\AbstractController->dispatch(Object(Laminas\\Http\\PhpEnvironment\\Request), Object(Laminas\\Http\\PhpEnvironment\\Response))\n#5 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(320): Laminas\\Mvc\\DispatchListener->onDispatch(Object(Laminas\\Mvc\\MvcEvent))\n#6 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(178): Laminas\\EventManager\\EventManager->triggerListeners(Object(Laminas\\Mvc\\MvcEvent), Object(Closure))\n#7 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/Application.php(319): Laminas\\EventManager\\EventManager->triggerEventUntil(Object(Closure), Object(Laminas\\Mvc\\MvcEvent))\n#8 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/public/index.php(37): Laminas\\Mvc\\Application->run()\n#9 {main}"

1 occurrences of :

- "laminas.route.name": "error"
+ "laminas.route.name": "error"
+ "runtime-id": "91690285-f43e-45ad-9c7a-7eeacf9e8896"

1 occurrences of :

- "name": "laminas.mvcEventListener"
+ "name": "laminas.route.match"

1 occurrences of :

- {
- "name": "laminas.route.match"
- "service": "test_laminas_20"
- "resource": "Laminas\\Router\\Http\\TreeRouteStack@match"
- "trace_id": 0
- "span_id": 18
- "parent_id": 12
- "type": "web"
- "meta": {
- "component": "laminas"
- }
- }
- "span_id": 19
+ "span_id": 18

3 occurrences of :

- "error.message": "Thrown Exception (500): Controller error in /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/module/Application/src/Controller/CommonSpecsController.php:33"
- "error.stack": "#0 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/Controller/AbstractActionController.php(72): Application\\Controller\\CommonSpecsController->errorAction()\n#1 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(320): Laminas\\Mvc\\Controller\\AbstractActionController->onDispatch()\n#2 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(178): Laminas\\EventManager\\EventManager->triggerListeners()\n#3 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/Controller/AbstractController.php(105): Laminas\\EventManager\\EventManager->triggerEventUntil()\n#4 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/DispatchListener.php(117): Laminas\\Mvc\\Controller\\AbstractController->dispatch()\n#5 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(320): Laminas\\Mvc\\DispatchListener->onDispatch()\n#6 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(178): Laminas\\EventManager\\EventManager->triggerListeners()\n#7 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/Application.php(319): Laminas\\EventManager\\EventManager->triggerEventUntil()\n#8 /home/circleci/datadog/tests/Frameworks/Laminas/Version_2_0/public/index.php(37): Laminas\\Mvc\\Application->run()\n#9 {main}"
+ "error.message": "Thrown Exception (500): Controller error in /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/module/Application/src/Controller/CommonSpecsController.php:33"
+ "error.stack": "#0 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/Controller/AbstractActionController.php(72): Application\\Controller\\CommonSpecsController->errorAction()\n#1 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(320): Laminas\\Mvc\\Controller\\AbstractActionController->onDispatch()\n#2 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(178): Laminas\\EventManager\\EventManager->triggerListeners()\n#3 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/Controller/AbstractController.php(105): Laminas\\EventManager\\EventManager->triggerEventUntil()\n#4 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/DispatchListener.php(117): Laminas\\Mvc\\Controller\\AbstractController->dispatch()\n#5 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(320): Laminas\\Mvc\\DispatchListener->onDispatch()\n#6 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-eventmanager/src/EventManager.php(178): Laminas\\EventManager\\EventManager->triggerListeners()\n#7 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/vendor/laminas/laminas-mvc/src/Application.php(319): Laminas\\EventManager\\EventManager->triggerEventUntil()\n#8 /home/circleci/app/tests/Frameworks/Laminas/Version_2_0/public/index.php(37): Laminas\\Mvc\\Application->run()\n#9 {main}"

1 occurrences of :

- "span_id": 27
- "parent_id": 19
+ "span_id": 26
+ "parent_id": 18

1 occurrences of :

- "span_id": 29
- "parent_id": 27
+ "span_id": 28
+ "parent_id": 26

1 occurrences of :

- "span_id": 23
+ "span_id": 22

1 occurrences of :

- "span_id": 24
+ "span_id": 23

1 occurrences of :

- "span_id": 25
+ "span_id": 24

1 occurrences of :

- "span_id": 28
- "parent_id": 25
+ "span_id": 27
+ "parent_id": 24

1 occurrences of :

- "span_id": 30
- "parent_id": 28
+ "span_id": 29
+ "parent_id": 27

1 occurrences of :

- "span_id": 31
- "parent_id": 28
+ "span_id": 30
+ "parent_id": 27

1 occurrences of :

- "span_id": 26
+ "span_id": 25

1 occurrences of :

- "parent_id": 11972289175454604309
+ "parent_id": 5795552262079558286

1 occurrences of :

- "laminas.route.name": "simpleView"
+ "_dd.p.tid": "65645cb500000000"

1 occurrences of :

- "name": "laminas.mvcEventListener"
+ "laminas.route.name": "simpleView"
+ "runtime-id": "05e49e0a-5ce8-4a67-9151-78ffaf427ea6"
+ "name": "laminas.route.match"

1 occurrences of :

- {
- "name": "laminas.route.match"
- "service": "test_laminas_20"
- "resource": "Laminas\\Router\\Http\\TreeRouteStack@match"
- "trace_id": 0
- "span_id": 19
- "parent_id": 12
- "type": "web"
- "meta": {
- "component": "laminas"
- }
- }
- "span_id": 20
+ "span_id": 19

1 occurrences of :

- "span_id": 23
- "parent_id": 20
+ "span_id": 22
+ "parent_id": 19

1 occurrences of :

- "span_id": 27
- "parent_id": 23
+ "span_id": 26
+ "parent_id": 22

1 occurrences of :

- "span_id": 24
- "parent_id": 20
+ "span_id": 23
+ "parent_id": 19

1 occurrences of :

- "span_id": 25
- "parent_id": 20
+ "span_id": 24
+ "parent_id": 19

1 occurrences of :

- "span_id": 26
- "parent_id": 21
+ "span_id": 25
+ "parent_id": 20

1 occurrences of :

- "span_id": 28
- "parent_id": 26
+ "span_id": 27
+ "parent_id": 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pablomartinezbernardo