Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Add ability to take state snapshot feature #4549

Draft
wants to merge 3 commits into
base: watson/DEBUG-2532/di
Choose a base branch
from

Conversation

watson
Copy link
Collaborator

@watson watson commented Jul 23, 2024

In scope:

  • Support for ReferenceDepth limit
  • Support for Length limit

Out of scope:

  • No support for CollectionSize limit
  • No support for FieldCount limit

Copy link
Collaborator Author

watson commented Jul 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @watson and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Jul 23, 2024

Overall package size

Self size: 7.04 MB
Deduped: 58.26 MB
No deduping: 58.54 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@watson watson self-assigned this Jul 23, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 23, 2024

Benchmarks

Benchmark execution time: 2024-08-29 09:44:37

Comparing candidate commit 9733dcf in PR branch watson/DEBUG-2605/snapshot with baseline commit f91b2de in branch watson/DEBUG-2532/di.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 262 metrics, 4 unstable metrics.

@watson watson force-pushed the watson/DEBUG-2605/snapshot branch from 8639412 to 60ed8b6 Compare July 25, 2024 06:50
@watson watson force-pushed the watson/DEBUG-2605/snapshot branch from 60ed8b6 to 8af7e4d Compare July 25, 2024 08:29
@watson watson force-pushed the watson/DEBUG-2605/snapshot branch from 8af7e4d to 39fea38 Compare July 25, 2024 08:37
@watson watson force-pushed the watson/DEBUG-2605/snapshot branch from 39fea38 to 30f6795 Compare July 25, 2024 10:36
@watson watson force-pushed the watson/DEBUG-2605/snapshot branch from 30f6795 to c214942 Compare July 25, 2024 10:37
@watson watson force-pushed the watson/DEBUG-2605/snapshot branch from c214942 to d4f1f8a Compare July 25, 2024 10:44
@watson watson force-pushed the watson/DEBUG-2605/snapshot branch from d4f1f8a to b6e69cd Compare July 25, 2024 11:53
@watson watson force-pushed the watson/DEBUG-2605/snapshot branch from b6e69cd to eb10ac7 Compare July 26, 2024 08:00
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.11%. Comparing base (e4bd929) to head (7dba831).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           watson/DEBUG-2532/di    #4549      +/-   ##
========================================================
- Coverage                 88.44%   88.11%   -0.33%     
========================================================
  Files                       263      259       -4     
  Lines                     11371    11303      -68     
  Branches                     33       33              
========================================================
- Hits                      10057     9960      -97     
- Misses                     1314     1343      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@watson watson force-pushed the watson/DEBUG-2532/di branch 5 times, most recently from ba9bc32 to c4b3d46 Compare September 2, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant