Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPM-4125] Refactor connection direction to be stateful based on SYN packets #32569

Closed
wants to merge 2 commits into from

Conversation

pimlu
Copy link
Contributor

@pimlu pimlu commented Dec 30, 2024

What does this PR do?

This PR uses the SYN from traffic as the connection direction and, importantly, refactors connection tuples within the TCP processor to not include connection direction. This is because the TCP processor can't infer connection direction from packet headers.

Motivation

More accurate handling of connection direction - previously it was calling determineConnectionDirection every packet instead of once when the connection is established. I think it was incidentally correct most of the time before, but this is more robust.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@pimlu pimlu added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Dec 30, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 51922501 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 20c010fda49b74b0c99a64b8f50e5219061008d8

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.01MB ⚠️ 1191.08MB 1191.07MB 140.00MB
datadog-agent-x86_64-rpm 0.01MB ⚠️ 1200.40MB 1200.39MB 140.00MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 1200.40MB 1200.39MB 140.00MB
datadog-agent-arm64-deb 0.00MB 935.37MB 935.37MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB 944.67MB 944.66MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.54MB 78.54MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.62MB 78.62MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.62MB 78.62MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.75MB 55.75MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.27MB 505.27MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.88MB 108.88MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51922501 --os-family=ubuntu

Note: This applies to commit 67a75b0

@pimlu pimlu closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/networks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant