[NPM-4125] Refactor connection direction to be stateful based on SYN packets #32569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR uses the SYN from traffic as the connection direction and, importantly, refactors connection tuples within the TCP processor to not include connection direction. This is because the TCP processor can't infer connection direction from packet headers.
Motivation
More accurate handling of connection direction - previously it was calling determineConnectionDirection every packet instead of once when the connection is established. I think it was incidentally correct most of the time before, but this is more robust.
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes