Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] Fix Mmap tests #32545

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[CWS] Fix Mmap tests #32545

wants to merge 8 commits into from

Conversation

mftoure
Copy link
Contributor

@mftoure mftoure commented Dec 30, 2024

What does this PR do?

This PR aims to fix the failing TestMMapEvent test. How ?
TestMmapEvent was failing because we were detecting an abnomal_path error that was coming from a previous test TestMkdirError.
The abnomal_path error was not detected in TestMkdirError when we ran validateAbnormalPaths on closing because:

  • the event with AbnormalPathRuleID was not handled yet
  • the rate_limiter did not send the most recent stats (as we use in validateAbnormalPaths to access wether there was an error or not)

So this PR makes sure that these 2 things are done for sure.

TestMmap is now passing

TestMkdirError is not failing as it should and needs to be fixed before merging this PR

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@mftoure mftoure added this to the 7.63.0 milestone Dec 30, 2024
@github-actions github-actions bot added team/agent-security short review PR is simple enough to be reviewed quickly labels Dec 30, 2024
@mftoure mftoure added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests and removed short review PR is simple enough to be reviewed quickly labels Dec 30, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 31, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 31, 2024

Uncompressed package size comparison

Comparison with ancestor 57183f81af4390123ce2a86f343ec42d8ef8eed0

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.03MB ⚠️ 1200.45MB 1200.43MB 140.00MB
datadog-agent-x86_64-suse 0.03MB ⚠️ 1200.45MB 1200.43MB 140.00MB
datadog-heroku-agent-amd64-deb 0.03MB ⚠️ 505.31MB 505.28MB 70.00MB
datadog-agent-amd64-deb 0.02MB ⚠️ 1191.14MB 1191.11MB 140.00MB
datadog-agent-aarch64-rpm 0.02MB ⚠️ 944.74MB 944.71MB 140.00MB
datadog-agent-arm64-deb 0.02MB ⚠️ 935.44MB 935.42MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.43MB 113.43MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.43MB 113.43MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.89MB 108.89MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.64MB 78.64MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.64MB 78.64MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.36MB 113.36MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.82MB 108.82MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 31, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51950643 --os-family=ubuntu

Note: This applies to commit 6f5f5bd

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 31, 2024

[Fast Unit Tests Report]

On pipeline 51950643 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Dec 31, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: efd22dee-76c4-493e-8f14-ba221a72f85f

Baseline: 57183f8
Comparison: 6f5f5bd
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.80 [+0.12, +1.49] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.13 [-0.64, +0.90] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.66, +0.76] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.05 [-0.59, +0.69] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.04 [-0.84, +0.92] 1 Logs
file_tree memory utilization +0.01 [-0.12, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.11, +0.10] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.87, +0.85] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.05 [-0.51, +0.41] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.08 [-0.99, +0.83] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.09 [-0.87, +0.68] 1 Logs
quality_gate_idle_all_features memory utilization -0.14 [-0.22, -0.06] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.27 [-0.30, -0.23] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -1.08 [-1.14, -1.01] 1 Logs
quality_gate_logs % cpu utilization -1.84 [-5.05, +1.37] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant