Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add WLAN Integration #32530

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

[WIP] Add WLAN Integration #32530

wants to merge 40 commits into from

Conversation

NouemanKHAL
Copy link
Member

@NouemanKHAL NouemanKHAL commented Dec 27, 2024

What does this PR do?

Adds a WLAN integration as a corecheck in the agent.

Motivation

Monitor the current Wi-Fi interface in use and collect various metrics to check the health of the Wi-Fi connection.
For now, the check collects the following data:

  • RSSI (Received signal strength indicator)
  • Transmit Rate
  • Channel Swap Events
  • Roaming Events

Describe how you validated your changes

  • Unit Tests
  • Manual Testing

Possible Drawbacks / Trade-offs

  • Requires Location Services Access on Mac OS

Additional Notes

Copy link

cit-pr-commenter bot commented Dec 27, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 42e1b907-dc67-4671-bbc6-4048d515bae8

Baseline: f3f94f9
Comparison: 008a33d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +0.38 [+0.34, +0.42] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.31 [-0.47, +1.10] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.24 [+0.19, +0.30] 1 Logs
file_tree memory utilization +0.22 [+0.09, +0.35] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.07 [-0.77, +0.90] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.65, +0.75] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.77, +0.84] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.10, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.91, +0.88] 1 Logs
quality_gate_idle_all_features memory utilization -0.03 [-0.12, +0.05] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput -0.07 [-0.84, +0.71] 1 Logs
quality_gate_logs % cpu utilization -0.09 [-3.34, +3.15] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.10 [-0.74, +0.55] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.31 [-0.78, +0.15] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -2.31 [-2.99, -1.64] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@NouemanKHAL
Copy link
Member Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Dec 27, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.


2024-12-27 10:02:52 UTC ℹ️ Gitlab pipeline started

Started pipeline #51839006

@NouemanKHAL
Copy link
Member Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Dec 27, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.


2024-12-27 11:23:59 UTC ℹ️ Gitlab pipeline started

Started pipeline #51841105

Copy link

cit-pr-commenter bot commented Dec 27, 2024

Go Package Import Differences

Baseline: f3f94f9
Comparison: 008a33d

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/net/wlan
agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/net/wlan
agentwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/net/wlan
agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/net/wlan
agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/net/wlan
iot-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/net/wlan
iot-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/net/wlan
heroku-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/net/wlan
cluster-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/net/wlan
cluster-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/net/wlan

@NouemanKHAL
Copy link
Member Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=off --variable RUN_E2E_TESTS=off --variable RUN_UNIT_TESTS=off --variable RUN_KMT_TESTS=off

@dd-devflow
Copy link

dd-devflow bot commented Dec 27, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.


2024-12-27 12:42:55 UTC ℹ️ Gitlab pipeline started

Started pipeline #51843048

@NouemanKHAL
Copy link
Member Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=off --variable RUN_E2E_TESTS=off --variable RUN_UNIT_TESTS=off --variable RUN_KMT_TESTS=off --variable MACOSX_DEPLOYMENT_TARGET=10.15

@dd-devflow
Copy link

dd-devflow bot commented Dec 27, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.


2024-12-27 13:54:22 UTC ℹ️ Gitlab pipeline started

Started pipeline #51845044

@NouemanKHAL
Copy link
Member Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=off --variable RUN_E2E_TESTS=off --variable RUN_UNIT_TESTS=off --variable RUN_KMT_TESTS=off

@dd-devflow
Copy link

dd-devflow bot commented Dec 28, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.


2024-12-28 08:23:58 UTC ℹ️ Gitlab pipeline started

Started pipeline #51866753

@NouemanKHAL NouemanKHAL changed the title [WIP] Noueman POC [WIP] Add WLAN Integration Dec 31, 2024
@NouemanKHAL NouemanKHAL added the qa/done QA done before merge and regressions are covered by tests label Dec 31, 2024
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51936024 --os-family=ubuntu

Note: This applies to commit 008a33d9

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor f3f94f940140d7162f150247daa89b5640a5940b

Diff per package
package diff status size ancestor threshold
datadog-heroku-agent-amd64-deb 1.43MB ⚠️ 506.70MB 505.27MB 70.00MB
datadog-agent-amd64-deb 1.41MB ⚠️ 1192.49MB 1191.08MB 140.00MB
datadog-agent-x86_64-rpm 1.41MB ⚠️ 1201.81MB 1200.40MB 140.00MB
datadog-agent-x86_64-suse 1.41MB ⚠️ 1201.81MB 1200.40MB 140.00MB
datadog-agent-arm64-deb 1.41MB ⚠️ 936.80MB 935.39MB 140.00MB
datadog-agent-aarch64-rpm 1.41MB ⚠️ 946.09MB 944.68MB 140.00MB
datadog-iot-agent-amd64-deb 0.02MB ⚠️ 113.36MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.02MB ⚠️ 113.43MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.02MB ⚠️ 113.43MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 108.82MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 108.89MB 108.88MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.54MB 78.54MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.62MB 78.62MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.62MB 78.62MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.75MB 55.75MB 10.00MB

Decision

⚠️ Warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/platform-integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant