Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack: enable full dead code elimination in binaries #32527

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pgimalac
Copy link
Member

What does this PR do?

Try enabling full dead code elimination to see impact on the size of binaries.

Motivation

Binary size reduction, estimated around 25%, as well as RSS reduction (unclear).

Describe how you validated your changes

N/A

Possible Drawbacks / Trade-offs

Additional Notes

This is a hack, I just commented out code to make it work, so no need to code-review this, and do not merge !

@github-actions github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Dec 26, 2024
@pgimalac pgimalac added the qa/rc-required Only for a PR that requires validation on the Release Candidate label Dec 26, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 26, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51828194 --os-family=ubuntu

Note: This applies to commit 6d36f3d

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 26, 2024

Uncompressed package size comparison

Comparison with ancestor 409fc489cd23371e4e56fdf96b6aade79a90ff50

Diff per package
package diff status size ancestor threshold
datadog-heroku-agent-amd64-deb 0.05MB ⚠️ 505.26MB 505.21MB 70.00MB
datadog-dogstatsd-x86_64-rpm -0.23MB 78.42MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse -0.23MB 78.42MB 78.65MB 10.00MB
datadog-dogstatsd-amd64-deb -0.23MB 78.34MB 78.57MB 10.00MB
datadog-agent-x86_64-rpm -8.11MB 1192.18MB 1200.29MB 140.00MB
datadog-agent-x86_64-suse -8.11MB 1192.18MB 1200.29MB 140.00MB
datadog-agent-amd64-deb -8.14MB 1182.86MB 1191.00MB 140.00MB
datadog-dogstatsd-arm64-deb -11.71MB 44.06MB 55.77MB 10.00MB
datadog-iot-agent-arm64-deb -22.42MB 86.40MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm -22.42MB 86.47MB 108.88MB 10.00MB
datadog-iot-agent-amd64-deb -23.56MB 89.79MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-rpm -23.56MB 89.86MB 113.42MB 10.00MB
datadog-iot-agent-x86_64-suse -23.56MB 89.86MB 113.42MB 10.00MB
datadog-agent-aarch64-rpm -93.87MB 850.70MB 944.57MB 140.00MB
datadog-agent-arm64-deb -93.89MB 841.41MB 935.30MB 140.00MB

Decision

⚠️ Warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe do-not-merge/hold long review PR is complex, plan time to review it qa/rc-required Only for a PR that requires validation on the Release Candidate team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant