Fix: Manifest request in `prod` failed due to a service execution timeout (#5528) #5595

achave11-ucsc · 2023-10-05T15:59:52Z

Connected issues: #5528

Checklist

Author

PR is a draft
Target branch is develop
Name of PR branch matches issues/<GitHub handle of author>/<issue#>-<slug>
On ZenHub, PR is connected to all issues it (partially) resolves
PR description links to connected issues
PR title matches¹ that of a connected issue _{or comment in PR explains why they're different}
PR title references all connected issues
For each connected issue, there is at least one commit whose title references that issue

¹ when the issue title describes a problem, the corresponding PR
title is Fix: followed by the issue title

Author (partiality)

Added p tag to titles of partial commits
This PR is labeled partial _{or completely resolves all connected issues}
This PR partially resolves each of the connected issues _{or does not have the partial label}

Author (chains)

This PR is blocked by previous PR in the chain _{or is not chained to another PR}
The blocking PR is labeled base _{or this PR is not chained to another PR}
This PR is labeled chained _{or is not chained to another PR}

Author (reindex, API changes)

Added r tag to commit title _{or the changes introduced by this PR will not require reindexing of any deployment}
This PR is labeled reindex:dev _{or the changes introduced by it will not require reindexing of dev}
This PR is labeled reindex:anvildev _{or the changes introduced by it will not require reindexing of anvildev}
This PR is labeled reindex:anvilprod _{or the changes introduced by it will not require reindexing of anvilprod}
This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
This PR is labeled reindex:partial and its description documents the specific reindexing procedure for dev, anvildev, anvilprod and prod _{or requires a full reindex or carries none of the labels reindex:dev, reindex:anvildev, reindex:anvilprod and reindex:prod}
This PR and its connected issues are labeled API _{or this PR does not modify a REST API}
Added a (A) tag to commit title for backwards (in)compatible changes _{or this PR does not modify a REST API}
Updated REST API version number in app.py _{or this PR does not modify a REST API}

Author (upgrading deployments)

Ran make image_manifests.json and committed the resulting changes _{or this PR does not modify azul_docker_images, or any other variables referenced in the definition of that variable}
Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading deployments}
Added u tag to commit title _{or this PR does not require upgrading deployments}
This PR is labeled upgrade _{or does not require upgrading deployments}
This PR is labeled deploy:shared _{or does not modify image_manifests.json, and does not require deploying the shared component for any other reason}
This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
This PR is labeled deploy:runner _{or does not require deploying the runner image}

Author (hotfixes)

Added F tag to main commit title _{or this PR does not include permanent fix for a temporary hotfix}
Reverted the temporary hotfixes for any connected issues _{or the none of the stable branches (anvilprod and prod) have temporary hotfixes for any of the issues connected to this PR}

Author (before every review)

Rebased PR branch on develop, squashed old fixups
Ran make requirements_update _{or this PR does not modify requirements*.txt, common.mk, Makefile and Dockerfile}
Added R tag to commit title _{or this PR does not modify requirements*.txt}
This PR is labeled reqs _{or does not modify requirements*.txt}
make integration_test passes in personal deployment _{or this PR does not modify functionality that could affect the IT outcome}

Peer reviewer (after approval)

PR is not a draft
Ticket is in Review requested column
PR is awaiting requested review from system administrator
PR is assigned to only the system administrator

System administrator (after approval)

Actually approved the PR
Labeled connected issues as demo or no demo
Commented on connected issues about demo expectations _{or all connected issues are labeled no demo}
Decided if PR can be labeled no sandbox
A comment to this PR details the completed security design review
PR title is appropriate as title of merge commit
N reviews label is accurate
Moved connected issues to Approved column
PR is assigned to only the operator

Operator (before pushing merge the commit)

System administrator

Background migrations for dev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
Background migrations for anvildev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
PR is assigned to only the operator

Operator (before pushing merge the commit)

Operator (chain shortening)

Changed the target branch of the blocked PR to develop _{or this PR is not labeled base}
Removed the chained label from the blocked PR _{or this PR is not labeled base}
Removed the blocking relationship from the blocked PR _{or this PR is not labeled base}
Removed the base label from this PR _{or this PR is not labeled base}

Operator (after pushing the merge commit)

Operator (reindex)

Operator

Propagated the deploy:shared, deploy:gitlab, deploy:runner, reindex:partial, reindex:anvilprod and reindex:prod labels to the next promotion PRs _{or this PR carries none of these labels}
Propagated any specific instructions related to the deploy:shared, deploy:gitlab, deploy:runner, reindex:partial, reindex:anvilprod and reindex:prod labels, from the description of this PR to that of the next promotion PRs _{or this PR carries none of these labels}
PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

coveralls · 2023-11-04T04:56:28Z

coverage: 83.813% (+0.01%) from 83.801%
when pulling b32b3ce on issues/achave11-ucsc/5528-disallow-manifests-while-reindexing
into 9f0b779 on develop.

codecov · 2023-11-04T04:56:31Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9f0b779) 83.78% compared to head (b32b3ce) 83.79%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5595      +/-   ##
===========================================
+ Coverage    83.78%   83.79%   +0.01%     
===========================================
  Files          152      152              
  Lines        19045    19047       +2     
===========================================
+ Hits         15956    15960       +4     
+ Misses        3089     3087       -2

Files	Coverage Δ
src/azul/health.py	`96.20% <100.00%> (+0.02%)`	⬆️
src/azul/service/queue_service.py	`28.19% <100.00%> (ø)`
test/indexer/test_indexer_controller.py	`99.35% <100.00%> (+<0.01%)`	⬆️
src/azul/azulclient.py	`53.76% <50.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hannes-ucsc

Commit title Promote Queues to QueueService and enforce its use in Health should be Rename Queues to QueueService and use it in HealthController

hannes-ucsc · 2024-03-10T23:49:37Z

src/azul/service/queue_service.py

Don't rename this file.

github-actions bot added the orange [process] Done by the Azul team label Oct 5, 2023

achave11-ucsc changed the title ~~Fix: Manifest request in prod failed due to a service execution timeout (#5528)~~ Fix: Manifest request in prod failed due to a service execution timeout (#5528) Oct 5, 2023

achave11-ucsc force-pushed the issues/achave11-ucsc/5528-disallow-manifests-while-reindexing branch 2 times, most recently from b614390 to a15abaa Compare October 5, 2023 16:53

achave11-ucsc force-pushed the issues/achave11-ucsc/5528-disallow-manifests-while-reindexing branch 2 times, most recently from 85c2fd5 to f173a7b Compare November 3, 2023 23:45

Promote Queues to QueueService and enforce its use in Health

b32b3ce

achave11-ucsc force-pushed the issues/achave11-ucsc/5528-disallow-manifests-while-reindexing branch from f173a7b to b32b3ce Compare November 4, 2023 04:38

achave11-ucsc force-pushed the develop branch from ed4b5e1 to 858f6fb Compare February 15, 2024 21:38

hannes-ucsc requested changes Mar 10, 2024

View reviewed changes

src/azul/service/queue_service.py

Copy link

Member

hannes-ucsc Mar 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't rename this file.

hannes-ucsc force-pushed the develop branch 3 times, most recently from 0762297 to 3f7f6ce Compare May 28, 2024 06:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Manifest request in `prod` failed due to a service execution timeout (#5528) #5595

Fix: Manifest request in `prod` failed due to a service execution timeout (#5528) #5595

achave11-ucsc commented Oct 5, 2023 •

edited

Loading

coveralls commented Nov 4, 2023

codecov bot commented Nov 4, 2023 •

edited

Loading

hannes-ucsc left a comment

hannes-ucsc Mar 10, 2024

Fix: Manifest request in prod failed due to a service execution timeout (#5528) #5595

Are you sure you want to change the base?

Fix: Manifest request in prod failed due to a service execution timeout (#5528) #5595

Conversation

achave11-ucsc commented Oct 5, 2023 • edited Loading

Checklist

Author

Author (partiality)

Author (chains)

Author (reindex, API changes)

Author (upgrading deployments)

Author (hotfixes)

Author (before every review)

Peer reviewer (after approval)

System administrator (after approval)

Operator (before pushing merge the commit)

System administrator

Operator (before pushing merge the commit)

Operator (chain shortening)

Operator (after pushing the merge commit)

Operator (reindex)

Operator

Shorthand for review comments

coveralls commented Nov 4, 2023

codecov bot commented Nov 4, 2023 • edited Loading

Codecov Report

hannes-ucsc left a comment

Choose a reason for hiding this comment

hannes-ucsc Mar 10, 2024

Choose a reason for hiding this comment

Fix: Manifest request in `prod` failed due to a service execution timeout (#5528) #5595

Fix: Manifest request in `prod` failed due to a service execution timeout (#5528) #5595

achave11-ucsc commented Oct 5, 2023 •

edited

Loading

codecov bot commented Nov 4, 2023 •

edited

Loading