make tab key insert tabs and set tab size to 4 in playground #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this accessible? How would a keyboard user navigate away from the text box? (We've discussed the escape key working in this case. Is that automatic somehow or do you need to add code?) |
|
I think using escape to unfocus the code editor and allow navigating to the next interactive element with tab is a good idea. It would also be nice to indent every line within the selection, if present, as well. |
|
escape to unfocus sounds like a good idea, indenting every selected line sounds a little tricky to implement so probably out of scope for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these changes make it so that you can easily use tabs in the playground