-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Saving Progress #8
base: experimental
Are you sure you want to change the base?
Conversation
Save positions
Random updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SaveGame class -> postfix tag but prefix function name
SendOnSaveGame -> while True, you sure about this ? Seems to be a copy paste too quick
The postfix tag but prefix function name seems weird, it should be a prefix tag to remove standard saving. However, this can still be merged since it doesn't have any issues. Data is sent fine. The "while true" I'm not sure how it got there, I can remove it next time but the data sending works fine. The code is right, I'm pretty sure that's just a leftover from what I was trying before. |
So why isn't it a prefix tag ?
I know where it come from and I can tell your its not a good thing haha. While true can overwhelm CPU really quickly, don't use it for a save, its dangerous. |
Main Changes:
Game Saving:
Current progress just consists of getting user data when the "SaveGame" button is pressed and storing this info in a SQLite table. The database model still needs some designing to be done and see how the data will actually be stored and fetched.
To-Do: