Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Saving Progress #8

Open
wants to merge 18 commits into
base: experimental
Choose a base branch
from

Conversation

Onfimarist
Copy link
Contributor

@Onfimarist Onfimarist commented Oct 4, 2022

Main Changes:

  • Added files for database management.
  • Added function to network dictionary for "GameSaving"
  • Removed unnecessary things and fixed a typo.
  • Disabled standard game saving (this would just create a new map in your game, not really needed for testing or anything, just don't release with this)

Game Saving:
Current progress just consists of getting user data when the "SaveGame" button is pressed and storing this info in a SQLite table. The database model still needs some designing to be done and see how the data will actually be stored and fetched.

To-Do:

  • Fetch player location data
  • Spawn player according to data

Copy link
Owner

@Damien2417 Damien2417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SaveGame class -> postfix tag but prefix function name
SendOnSaveGame -> while True, you sure about this ? Seems to be a copy paste too quick

@Damien2417 Damien2417 changed the base branch from master to Development October 4, 2022 09:01
@Onfimarist
Copy link
Contributor Author

SaveGame class -> postfix tag but prefix function name

SendOnSaveGame -> while True, you sure about this ? Seems to be a copy paste too quick

The postfix tag but prefix function name seems weird, it should be a prefix tag to remove standard saving. However, this can still be merged since it doesn't have any issues. Data is sent fine.

The "while true" I'm not sure how it got there, I can remove it next time but the data sending works fine. The code is right, I'm pretty sure that's just a leftover from what I was trying before.

@Damien2417 Damien2417 changed the base branch from development to experimental October 6, 2022 09:42
@Damien2417
Copy link
Owner

The postfix tag but prefix function name seems weird, it should be a prefix tag to remove standard saving. However, this can still be merged since it doesn't have any issues. Data is sent fine.

So why isn't it a prefix tag ?

The "while true" I'm not sure how it got there, I can remove it next time but the data sending works fine. The code is right, I'm pretty sure that's just a leftover from what I was trying before.

I know where it come from and I can tell your its not a good thing haha. While true can overwhelm CPU really quickly, don't use it for a save, its dangerous.
You gotta understand what you're doing, working code doesn't mean good code 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants