-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Output Improvements #2
Conversation
Shows the difficulty of the roll as part of the 'Sucessess' output on the skill roll, so it is clear what difficulty you were rolling against. Also I changed the default for difficulty to be 0 if it is omitted on the command line, if this should not be possible then the command parsing should be checked over.
Changes the dice displayed in the results of a combat role to emoji representing the faces of a Fallout 2d20 combat die.
The filler text at the top of combat rolls was still the 'success' and 'failure' text from the skill roll. It has now been replaced with combat appropriate text showing the difference between hits for 0 damage, regular damage, or criticals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments but overall I think the changes are great. Let me know what you think and we can get these merged. I have a game tomorrow with my group so I can give them a proper test run.
Remove critical related text as critical hits are not certain.
Merged, thanks for contributing! Going to test it out tomorrow and tag it for release if it goes well. |
Hmm, interesting. I'll have to look into it more, they are a bit mysterious. |
Aha! Ok, it seems that the bot must be a member of the server that the emoji is from. So your instance of the bot can't get the emoji from the server that my instance is in. |
We might want to setup something where by default it uses emoji that are associated with the copy of the bot you run, but setup so that they can be changed for someone running a seperate instance. |
This may have been an issue with the bot's permissions. I updated them to request the "Use External Emoji" setting and tested it out in a new server and that seems to work! I have also hosted the bot, so there is a live instance of the bot now. I have it running off the next branch currently to test things out but will be updating it to go back to using the main branch when I do the next release. |
A few different tweaks to improve some of the outputs of the bot for various commands.
For skills this adds the display of the roll difficulty as part of the command output as shown here:
For combat rolls this both changes up the flavour text from the existing text copied from the skills command to new combat roll specific text. It also replaces the dice roll visualisation for combat rolls with emoji showing the Fallout 2d20 combat die faces rather than simply numbers.