Lint and format #164
Merged
Lint and format #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you looking for a review, @thodson-usgs? |
|
@ehinman |
ehinman
reviewed
Sep 25, 2024
| df.dec_long_va.values, | ||
| df.dec_lat_va.values | ||
| ) | ||
| geoms = gpd.points_from_xy(df.dec_long_va.values, df.dec_lat_va.values) |
There was a problem hiding this comment.
This change seems a little weird, from multiple lines to one line, but not a biggie. I'm assuming this means that the line is less than 72 spaces.
There was a problem hiding this comment.
right, a little annoying but i'd live with this instance. Others might be worse such that we should try to address it now
ehinman
reviewed
Sep 25, 2024
| ... ) | ||
| >>> # Search for features for comid: 13294314, | ||
| >>> # and data source: census2020-nhdpv2 in the upstream main | ||
| >>> search_results = dataretrieval.nldi.search( | ||
| ... comid=13294314, data_source="census2020-nhdpv2", navigation_mode="UM" | ||
| ... comid=13294314, |
ehinman
reviewed
Sep 25, 2024
| @@ -8,11 +8,12 @@ | |||
| - implement other services like Organization, Activity, etc. | |||
|
|
|||
| """ | |||
|
|
|||
There was a problem hiding this comment.
Seems like a random space addition?
ehinman
approved these changes
Sep 25, 2024
| assert df.index.names == [ | ||
| SITENO_COL, | ||
| DATETIME_COL, | ||
| ], "iv service returned incorrect index: {}".format(df.index.names) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatter did pretty well. I might tweak a couple things later, but we'll do that via the config.
We could add precommit hooks to enforce this stuff too but that can create hassle for new contributors. Let's start easy.