Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(future warning fix): wrapping pd.read_json arg in StringIO to suppre… #112

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

mnfienen
Copy link
Contributor

…ss pandas future warning about not passing a str

Quick fix to address future warning in pandas 2.1.0 regarding passing str to read_json as used in nwis.py

…ss pandas future warning about not passing a str
Copy link
Collaborator

@thodson-usgs thodson-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contributing!

@thodson-usgs thodson-usgs merged commit f6d18aa into DOI-USGS:master Sep 25, 2023
10 checks passed
@mnfienen
Copy link
Contributor Author

no worries! This is a great tool and we are incorporating it into our github.com/doi-usgs/python-for-hydrology class for USGS folks. I'm glad you guys took this on!

@mnfienen mnfienen deleted the future_warning_json branch September 25, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants