-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALE Driver Architecture #48
Conversation
|
||
## Ale::load | ||
|
||
- ? Not sure exactly what is intended for this section ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to cover how loads works. That is, how it iterates over each driver and attempts to build an ISD with each. How loads quick rejects ISDs (using instrument IDs, look at the code and instructions for how to make an ale driver for examples). And how this can sometimes cause issues (sometimes a driver can succeed before the driver you want).
Also mention isd_generate as an app that can do most of the boilerplate for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sometimes a driver can succeed before the driver you want
I mentioned this in my current draft, but I don't think I've seen this issue myself. Would different instrument_id
s prevent this from happening? What can someone do if that happens to them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good encapsulation of the ALE architecture, couple things to address when talking about ISIS cameras
My concerns have been addressed, if @acpaquette also gives a +1 then this is good to merge. |
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:
Addresses the conceptual points in #32