Changes python version specification #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelvinrr
reviewed
Oct 27, 2024
| @@ -27,7 +27,7 @@ This installation guide is for ISIS users interested in installing ISIS (3.6.0)+ | |||
| export CONDA_SUBDIR=osx-64 | |||
|
|
|||
| #Create a new conda environment to install ISIS in | |||
| conda create -n isis python=3.9 | |||
| conda create -n isis python>=3.9 | |||
There was a problem hiding this comment.
I imagine It would be fine to not specify a python version at all?
There was a problem hiding this comment.
There was a previous issue regarding NOT setting the python version. Let me see if I can find it
|
Here is the original ISIS issue that requested we update the docs to set the python version: DOI-USGS/ISIS3#5319 |
Kelvinrr
approved these changes
Nov 18, 2024
jrcain-usgs
pushed a commit
to jrcain-usgs/asc-public-docs
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the python version spec to look for python versions equal to or greater than 3.9 when installing ISIS
Fixes #113
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: