Reduce symbol exposure #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an ELF shared object (by convention, a file named as lib*.so), all symbols are marked as public, hence included in the object's export symbol table. This commit reduces exported symbol by marking proper 'static'. [old] $ size build/libdcurl.so text data bss dec hex filename 16752 924 160 17836 45ac build/libdcurl.so [new] size build/libdcurl.so text data bss dec hex filename 15936 836 168 16940 422c build/libdcurl.so TODO: there are various way to control over symbol exports in GCC: * compiler flag -fvisibility=hidden * Using `ld' linker version script Once we confirm consistent API naming scheme, we can then apply these techniques.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an ELF shared object (by convention, a file named as
lib*.so), all symbols are marked as public, hence included in the
object's export symbol table. This commit reduces exported symbol
by marking proper 'static'.
[old]
$ size build/libdcurl.so
text data bss dec hex filename
16752 924 160 17836 45ac build/libdcurl.so
[new]
size build/libdcurl.so
text data bss dec hex filename
15936 836 168 16940 422c build/libdcurl.so
TODO: there are various way to control over symbol exports in GCC:
Once we confirm consistent API naming scheme, we can then apply these
techniques.