Never invoke exit(3) within library implementation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is dangerous and irresponsible to invoke exit(3) in a certain library consisting of several functions. Outer developers would never understand why their programs exit when linking to dcurl. Instead, we should always ensure the appropriate return values and transit state machine internally. TODO: the following files are not changed accordingly because function prototypes have to be modified in order to reflect return values: * src/clcontext.c * src/pow_cl.c * src/dcurl.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is dangerous and irresponsible to invoke exit(3) in a certain library
consisting of several functions. Outer developers would never understand
why their programs exit when linking to dcurl. Instead, we should always
ensure the appropriate return values and transit state machine
internally.
TODO: the following files are not changed accordingly because function
prototypes have to be modified in order to reflect return values: