Canonicalize build targets and allow custom config #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous commits, there are some inconsistent build targets. It is time to unify them: * Inside GNU make, conditions start with `BUILD_`. * Inside C source files, macros start with `ENABLE_`. `build/local.mk` can be modified in advance, and new build system would defer it for conditional build targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous commits, there are some inconsistent build targets. It is
time to unify them:
BUILD_.ENABLE_.build/local.mkcan be modified in advance, and new build system woulddefer it for conditional build targets.