Better Java integration #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jserv
commented
Mar 18, 2018
jserv
commented
- Move Java build rules out of top-level Makefile;
- Use javah to generate JNI header from latest Java source;
- Defer to JAVA_HOME setting;
File jni/iri-pearldiver-exlib.h was generated out of source tree, which might be not sychronized to new interface specific to `com.iota.iri.hash.PearlDiver`. This commit ensures the generated JNI header consistent to latest Java source.
This commit improves the detection of JDK and allows custom JAVA_HOME configuration, which is important to deployment.
|
This feature is great! Thanks a lot. |
|
Alternatively, developers should be able to specify IRI source path rather than downloading from GitHub. |
|
[verified] Compatible with IRI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.