Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix car_index bug #58

Open
schakalakka opened this issue Jan 23, 2023 · 1 comment
Open

Fix car_index bug #58

schakalakka opened this issue Jan 23, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@schakalakka
Copy link
Member

There is a bug regarding the car_index in the resulting trip_table after a tapas run. Only the first car in a household is used even it is already book by another household member,

@schakalakka schakalakka added the bug Something isn't working label Jan 23, 2023
@schakalakka
Copy link
Member Author

schakalakka commented Jan 23, 2023

a first fix for the car_index bug

now the second car of a household will be used.

See commit 7a18a6e in branch fix_car_index_bug_second_attempt.

There are still some issues:

  1. Sometimes members use a car which is already booked at that time (see TPS_Worker.java line 129)
  2. Is the car wrongfully assigned to several households? No handling in this case so far.
  3. There are basically two cases: One for Household Member-sorting COST_OPTIMUM and one for the rest. It is also not clear why the second case works at all.
  4. Sometimes there are a set of plans for a person and ALL of them are infeasible. Why? And why are infeasible plans not dismissed immediately anyway?

So far it is not merged with master but it will be eventually. It is needed for the TAPAS-CURRENT interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant