Refactor unretire-anyone code and make it a module so you can access its naming scheme function #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
Jul 19, 2024
| @@ -39,59 +36,80 @@ function addNemesisToUnretireList(advSetUpScreen, nemesis, index) | |||
| advSetUpScreen.nemesis_index:insert('#', index) | |||
| end | |||
|
|
|||
| function getHistfigShortSummary(histFig) | |||
There was a problem hiding this comment.
Could you rewrite this to make use of dfhack.units.getReadableName(histFig)? Most of the logic is covered by that function.
Which other tool needs access to this function? Can they also use getReadableName?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now you can get unretire-anyone-style summary of a nemesis