Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSR-777 Bump node to v18 #454

Merged
merged 2 commits into from
Aug 2, 2023
Merged

FSR-777 Bump node to v18 #454

merged 2 commits into from
Aug 2, 2023

Conversation

maxcbc
Copy link
Contributor

@maxcbc maxcbc commented Jul 6, 2023

Bumps node to v18.

Includes:

  • updating engines in package.json
  • adding .nvmrc file
  • updating incompatible dependencies:
    • node-sass to v9 (adds node 18 support)
    • @hapi/lab to v25 (prevents leak detection on non-enumerable global variables, which are deliberately modified by node itself in node 18)
    • pinned datatables.net-dt to v1.12 (v1.13 and above uses css variables which breaks the build and also needs to be checked for browser support)

@maxcbc maxcbc force-pushed the feature/FSR-777 branch 2 times, most recently from 1610532 to d69a551 Compare July 6, 2023 10:04
@maxcbc maxcbc marked this pull request as ready for review July 7, 2023 09:47
@maxcbc maxcbc changed the base branch from master to development July 7, 2023 12:46
@maxcbc maxcbc force-pushed the feature/FSR-777 branch 2 times, most recently from aef4925 to b7e8cc6 Compare July 13, 2023 10:16
Max Bladen-Clark added 2 commits August 2, 2023 10:51
Includes updating engines, bumping incompatible packages, adding .nvmrc file and bumping version in ci workflow
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nikiwycherley nikiwycherley merged commit 7a3928a into development Aug 2, 2023
6 checks passed
@nikiwycherley nikiwycherley deleted the feature/FSR-777 branch August 2, 2023 10:07
maxcbc added a commit that referenced this pull request Aug 16, 2023
* Bump node from v16 to v18

https://eaflood.atlassian.net/browse/FSR-777

* Update package.json to node v18

Includes updating engines, bumping incompatible packages, adding .nvmrc file and bumping version in ci workflow

---------

Co-authored-by: Max Bladen-Clark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants