FSR-705 Accessibility Changes #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeGordon83
changed the title
LeeGordon83
changed the title
LeeGordon83
force-pushed
the
feature/FSR-705
branch
from
d6b7739
to
bfa3977
Compare
LeeGordon83
force-pushed
the
feature/FSR-705
branch
from
77b2d47
to
070e73a
Compare
maxcbc
reviewed
Jul 10, 2023
maxcbc
reviewed
Jul 10, 2023
maxcbc
previously requested changes
Jul 10, 2023
|
Code looks fine other than some small finickity bits. Have not pulled down and checked with screen reader. When this PR is ready I'll check with screen reader. |
LeeGordon83
force-pushed
the
feature/FSR-705
branch
2 times, most recently
from
6aed404
to
55346a8
Compare
maxcbc
changed the title
LeeGordon83
force-pushed
the
feature/FSR-705
branch
from
13e21a3
to
f5b3639
Compare
neilbmclaughlin
force-pushed
the
development
branch
from
b0127e4
to
3803675
Compare
LeeGordon83
force-pushed
the
feature/FSR-705
branch
2 times, most recently
from
7fb25cf
to
f823ae0
Compare
LeeGordon83
force-pushed
the
feature/FSR-705
branch
from
5f1fc8b
to
678e26b
Compare
maxcbc
force-pushed
the
feature/FSR-705
branch
from
ca1aa41
to
3e0296e
Compare
maxcbc
force-pushed
the
feature/FSR-705
branch
2 times, most recently
from
2380958
to
ea8124f
Compare
…front end to display new station chart, uunit tests also fixed
maxcbc
force-pushed
the
feature/FSR-705
branch
from
ea8124f
to
7eaf8b1
Compare
|
Kudos, SonarCloud Quality Gate passed! |
nikiwycherley
approved these changes
Aug 16, 2023
nikiwycherley
dismissed
maxcbc’s stale review
have talked it through on separate call
maxcbc
pushed a commit
that referenced
this pull request
Aug 18, 2023
* update to release notes * Accessibility Fixes https://eaflood.atlassian.net/browse/FSR-705 https://eaflood.atlassian.net/browse/FSR-701 https://eaflood.atlassian.net/browse/FSR-886 * altered telemetry model to match prototype data set, change relevant front end to display new station chart, uunit tests also fixed * altered line thickness on historical events chart * threshold label error fixed * removed forecast html that isn't needed yet from station page * added forecast banner. Amended all other banners to load banner svg as part of model * code smells removed * further code smell cleared * removal of duplicate core.js script call in station.html * bug relating to font on station page sorted * fixed broken map loading from station link issue, also implemented suggested code changes on PR * fixed graph zoom issue * threshold-label * fix threshold display issue * add explicit unsetting of color in css for svgs in high contrast mode also add missing inline svg for chevron in secondary start button * remove transparent outline on search button * add thin top, right and bottom border to status items in high contrast mode * Fix SVG in nav and tables on high contrast * Add explicit support for high contrast mode on line charts * Add client side test for bar-chart controls, refactor bar-chart code to separate dir * Add pagination tests * extract update control methods into separate files * extract control creation from main bar-chart method * Update resolution display text on bar-chart * move pagination controls on bar-chart into controls row and update display text * update bar-chart resolution controls to use buttons rather than inputs * rename segmented controls to resolution controls * update class name for pagination buttons on bar chart * update resolution and pagination ontrols to be more generic * Update bar chart css for high contrast mode * update client side tests to be less flakey * update high contrast mode media queries to use mixin * remove upstream/downstream icons * subnav markup and contrast fix. Amended unit tests to reflect * fix issues with bells and warning triangles on hcm * fix outlook map button * remove background on chart buttons when focussed in hcm mode * remove full stop from sign-up-for-flood-warnings * fix custom class support on map buttons --------- Co-authored-by: nikiwycherley <[email protected]> Co-authored-by: Max Bladen-Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/FSR-705
https://eaflood.atlassian.net/browse/FSR-701
https://eaflood.atlassian.net/browse/FSR-886