Refactor station-csv.js to improve code readability and maintainability

DEFRA · Aug 7, 2024 · d0db2b0 · d0db2b0
1 parent b3d50c0
commit d0db2b0
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 112 deletions.
diff --git a/test/routes/station-csv.js b/test/routes/station-csv.js
@@ -142,13 +142,7 @@ lab.experiment('Routes test - station-csv', () => {
       }
     ]
 
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
 
     sandbox.stub(floodService, 'getStationById').callsFake(fakeStationData)
     sandbox.stub(floodService, 'getStationTelemetry').callsFake(fakeTelemetryData)
@@ -221,13 +215,7 @@ lab.experiment('Routes test - station-csv', () => {
       }
     ]
 
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
 
     sandbox.stub(floodService, 'getStationById').callsFake(fakeStationData)
     sandbox.stub(floodService, 'getStationTelemetry').callsFake(fakeTelemetryData)
@@ -300,13 +288,7 @@ lab.experiment('Routes test - station-csv', () => {
       }
     ]
 
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
 
     sandbox.stub(floodService, 'getStationById').callsFake(fakeStationData)
     sandbox.stub(floodService, 'getStationTelemetry').callsFake(fakeTelemetryData)
@@ -338,13 +320,7 @@ lab.experiment('Routes test - station-csv', () => {
       }
     ]
 
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
 
     sandbox.stub(floodService, 'getStationById').callsFake(fakeStationData)
     sandbox.stub(floodService, 'getStationTelemetry').callsFake(fakeTelemetryData)
@@ -374,13 +350,7 @@ lab.experiment('Routes test - station-csv', () => {
       }
     ]
 
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
 
     sandbox.stub(floodService, 'getStationById').callsFake(fakeStationData)
     sandbox.stub(floodService, 'getStationTelemetry').callsFake(fakeTelemetryData)

diff --git a/test/routes/station.js b/test/routes/station.js
@@ -208,13 +208,7 @@ lab.experiment('Test - /station/{id}', () => {
         forecastactive: false
       }
     ]
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
 
     const fakeStationForecastData = () => []
     const fakeWarningsAlertsData = () => []
@@ -351,13 +345,7 @@ lab.experiment('Test - /station/{id}', () => {
     ]
 
     const fakeImpactsData = () => []
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
     const fakeTargetAreasData = () => []
     const fakeStationThresholdData = () => []
 
@@ -495,13 +483,7 @@ lab.experiment('Test - /station/{id}', () => {
     ]
 
     const fakeImpactsData = () => []
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
     const fakeWarningsAlertsData = () => []
     const fakeStationThresholdData = () => []
 
@@ -634,13 +616,7 @@ lab.experiment('Test - /station/{id}', () => {
     ]
 
     const fakeImpactsData = () => []
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
     const fakeWarningsAlertsData = () => []
     const fakeStationThresholdData = () => []
 
@@ -738,13 +714,7 @@ lab.experiment('Test - /station/{id}', () => {
     const fakeTelemetryData = () => []
 
     const fakeImpactsData = () => []
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
     const fakeWarningsAlertsData = () => []
     const fakeRiverStationData = () => []
     const fakeStationThresholdData = () => []
@@ -878,13 +848,7 @@ lab.experiment('Test - /station/{id}', () => {
     ]
 
     const fakeImpactsData = () => []
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
     const fakeWarningsAlertsData = () => []
     const fakeStationThresholdData = () => []
 
@@ -1020,13 +984,7 @@ lab.experiment('Test - /station/{id}', () => {
     ]
 
     const fakeImpactsData = () => []
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
     const fakeWarningsAlertsData = () => []
     const fakeStationThresholdData = () => []
 
@@ -1606,13 +1564,7 @@ lab.experiment('Test - /station/{id}', () => {
     ]
 
     const fakeImpactsData = () => []
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
 
     const fakeTargetAreasData = () => []
     const fakeStationThresholdData = () => []
@@ -1903,13 +1855,7 @@ lab.experiment('Test - /station/{id}', () => {
     ]
 
     const fakeImpactsData = () => []
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
 
     const fakeTargetAreasData = () => []
     const fakeStationThresholdData = () => []
@@ -2043,13 +1989,7 @@ lab.experiment('Test - /station/{id}', () => {
     ]
 
     const fakeImpactsData = () => []
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
     const fakeTargetAreasData = () => []
     const fakeStationThresholdData = () => { return {} }
 
@@ -2180,13 +2120,7 @@ lab.experiment('Test - /station/{id}', () => {
     ]
 
     const fakeImpactsData = () => []
-    const fakeForecastFlag = () => [{
-      station_display_time_series_id: '94280',
-      station_id: '8208',
-      direction: 'u',
-      display_time_series: true
-    }
-    ]
+    const fakeForecastFlag = () => { return { } }
     const fakeTargetAreasData = () => []
     const fakeStationThresholdData = () => []