Filter damaged ships from airbase export #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurounijones
approved these changes
Dec 11, 2023
rurounijones
requested changes
Dec 11, 2023
|
As |
|
Could you rebase this brqnch on main and fix the conflict, then I can merge. |
mobot-gh
force-pushed
the
shipabexport
branch
from
e947984
to
cfc0286
Compare
rurounijones
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that:
The
getAirbasesmethod fromWorldServicecan fail with an error if it is called while a ship is in this static state, as the exporter attempts to access the group the airbase unit belongs to, which does not exist.This PR filters out these static ships by performing nil checks for the unit & group before attempting to export.