Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close config file after reading #239

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Close config file after reading #239

merged 2 commits into from
Oct 19, 2023

Conversation

Applevangelist
Copy link
Contributor

Close file after success to remove lock

@Applevangelist
Update DCS-gRPC.lua
6d52c8e 
Close file after success to remove lock
@Applevangelist Applevangelist mentioned this pull request Oct 15, 2023
Closed
@rurounijones rurounijones changed the title Update DCS-gRPC.lua Close Config file after reading Oct 18, 2023
@rurounijones
Copy link
Contributor

Thanks for the change. Could you update the CHANGELOG.md file as well with your change. e.g. In the FIXED section of the unreleased version add the fact that the config file is now being closed.

@rurounijones
Copy link
Contributor

@rkusa Looks like the codebase is failing the latest version of the linter

@rurounijones rurounijones changed the title Close Config file after reading Close config file after reading Oct 18, 2023
@rkusa
Copy link
Collaborator

rkusa commented Oct 19, 2023

@rkusa Looks like the codebase is failing the latest version of the linter

#241 👍

@rurounijones
Copy link
Contributor

Bypassing protection since the part that is failing is a linter that is fixed elsewhere.

@rurounijones rurounijones merged commit db2b21d into DCS-gRPC:main Oct 19, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Applevangelist @rurounijones @rkusa