Linting: implemented suggestions for coalition.proto #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-lovell
commented
Jan 15, 2022
Primary motivation to be a commit is due to CHANGELOG.md update and for a discussion on the API itself being affected. Lint to disable the default SUFFIX to be "INVALID" nor "UNSPECIFICIED" on `SKILL_RANDOM` and `POINT_TYPE_RANDOM` because the mission designer experiences this as the default impelementation
justin-lovell
commented
Jan 17, 2022
There was a problem hiding this comment.
For this PR, I feel that this is not useful to my time. I personally would rewrite the entire AddGroupRequest and friends ... most of the members don't comply with the linting, and most importantly, the transgressors of the linting issues has no implementation!
Let us get the linting under order (because that is a common call out on every PR), or just eliminate the members which is not implemented.
justin-lovell
changed the title
rurounijones
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary motivation to be a commit is due to CHANGELOG.md update
and for a discussion on the API itself being affected.
Work motivated by corrected #111 but separated PR as there are some discussion points
on how to resolve some design issues. Comment inline the PR below.