-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing GroupCategory
enumeration
#112
Fixing GroupCategory
enumeration
#112
Conversation
GroupCategory
enumeration.GroupCategory
enumeration.
This would take a while to fully implement because the implementation here is incorrect -- previously it would have only gotten the airplanes only, and not the other unit types. Lines 49 to 52 in 3f44688
I'm considering we change the |
GroupCategory
enumeration.GroupCategory
enumeration
GroupCategory
enumerationGroupCategory
enumeration
If we add this filter, we'd also have to filter the units added in the following line (where it listens for birth events): https://github.com/DCS-gRPC/rust-server/blob/main/src/stream.rs#L138 |
Motivated by work in progress with PR #111. Communicating breaking changes and configuring to change log and updating behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justin-lovell It looks, to me that there are 3 commits in this PR and the latter 2 might accidentally have not been squashed together.
Could you check on your end and squash them if they are supposed to be; or change the commit messages (They are currently identical) to be more specific to the commit goal if you think they should be separate commits.
Primary motivation is to ensure consistency with the underlying `GetGroups` implementation. Additional benefit is that different polling rates may be specified to the different categories. This makes sense because jets fly faster than ground units!
@rurounijones -- yeah, the last one was my bad. I must have forgotten the amend. Having the two commits is recording good history. One was for the linting, and the second one is to align |
Motivated by work in progress with PR #111. Communicating
breaking changes and configuring to change log and updating
behavior