Calibrate timestamp field UI tweak #4992
Open
+75
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S/4904-calibrate-timestamp-field-ui-tweak
Tom-Szendrey
requested review from
YohannParis,
mwdchang,
jryu01,
shawnyama,
blanchco and
asylves1
as code owners
…S/4904-calibrate-timestamp-field-ui-tweak
shawnyama
reviewed
Oct 1, 2024
| <span class="column-header"></span> | ||
| </template> | ||
| <template #body="{ data }"> | ||
| <Button class="p-button-sm p-button-text" icon="pi pi-trash" @click="deleteMapRow(data.id)" /> |
There was a problem hiding this comment.
I don't think time should have a delete button, designs don't have it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
delete all mappingswe will keep a mapping fortimestampWarning:
This updates the state object for calibration so older calibration nodes will run into issues with their mappings.
Pics
With designs here: https://www.figma.com/design/SLO56PGmGq7kFQRFCeaPsY/Terarium---September-2024?node-id=235-584&node-type=canvas&t=3E0tQ1xlWHmsXuxp-0