weighted interventions #4986
Open
weighted interventions #4986
+127
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will need to merge this first: |
blanchco
requested review from
dgauldie,
dvince2,
YohannParis,
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama and
asylves1
as code owners
dgauldie
reviewed
Oct 1, 2024
...client/src/components/workflow/ops/optimize-ciemss/tera-static-intervention-policy-group.vue
Outdated
Show resolved
Hide resolved
Tom-Szendrey
reviewed
Oct 1, 2024
| const inactivePolicyGroups = computed(() => knobs.value.interventionPolicyGroups.filter((ele) => !ele.isActive)); | ||
| const inactivePolicyGroups = computed(() => |
There was a problem hiding this comment.
This should also include any groups that have a relative weight of 0.
If a user plugs in a static intervention that they do not want to optimize over but they want to have impact this is known as a fixed_static_parameter_interventions or a fixed_static_state_interventions Both of these should still be available to the user
See line 789 in this file
There was a problem hiding this comment.
This should include those groups that have relative weight of 0. If ele.relativeImportance is 0 this is falsy and will be added to the inactive policy groups
Tom-Szendrey
reviewed
Oct 1, 2024
packages/client/hmi-client/src/components/widgets/tera-signal-bars.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warning:
Old optimize nodes will not be functional after this is merged
Note required:
DARPA-ASKEM/pyciemss-service#121