Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funman output charts #4923

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Funman output charts #4923

wants to merge 15 commits into from
+332 −524

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Sep 25, 2024 •
edited
Loading

Description

  • State chart and parameter charts to show the true/false boxes of the funman result
  • Will handle ambiguous lines in a second pass
  • There seems to be an issue with the states/outputs being saved, I have to redo things sometimes on reload. Might be a workflow saving problem will have to see in another task.

image

@shawnyama shawnyama linked an issue Oct 1, 2024 that may be closed by this pull request
[FEAT]: funman redesign (output panel) #4793
Open
@shawnyama shawnyama marked this pull request as ready for review October 1, 2024 13:45
YohannParis
YohannParis reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove those gollm/gollm_task.egg-info folder and files.
Update from main to have your .gitignore up to snuff.

@shawnyama shawnyama changed the title Funman output Funman output charts Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis left review comments

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: funman redesign (output panel)
2 participants
@shawnyama @YohannParis