Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use refactored PyCIEMSS lib #50

Merged
merged 15 commits into from
Jan 10, 2024
Merged

Use refactored PyCIEMSS lib #50

merged 15 commits into from
Jan 10, 2024

Conversation

fivegrant
Copy link
Collaborator

@fivegrant fivegrant commented Nov 2, 2023

This PR refactors the service to use PyCIEMSS v0.1. The changes to the API are kept to a minimum but alterations are unavoidable since we are moving from "big box" to "small box" (atomic) operations.

PyCIEMSS features that still need to be incorporated into the service

  • Pass parameters.dill into simulate (i.e. using inferred_parameters from calibrate for sample)
  • Reimplement interventions (unclear which kind of interventions I should expose)
  • Fix solution mappings for ensemble-simulate to work with the new format

Regressions that have now been fixed but need to be incorporated into service

  • Progress hook with additional 'loss' field.

Regressions in PyCIEMSS

@fivegrant fivegrant changed the title Begin tracking refactor changes Use refactored PyCIEMSS lib Nov 3, 2023
@fivegrant fivegrant self-assigned this Nov 6, 2023
@fivegrant
Copy link
Collaborator Author

Please note the following regressions

tl;dr: simulate and calibrate have been successfully refactored while there are various issues with everything else

Dashboard Results

image
simulate and calibrate now work for all except one models. This includes stockflow and regnets. All of the other other operations no longer pass

@fivegrant fivegrant merged commit 1f13594 into main Jan 10, 2024
2 checks passed
@fivegrant fivegrant deleted the staging/refactor branch January 10, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants