Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolInformation - Equals, HashCode, and multi-tool parsing fixes w/tests #396

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gdgib-roche
Copy link

  1. The new ToolInformation class did not have equals & hashCode methods, which prevented equality checks during downstream unit testing
  2. The custom deserializer for ToolInformation did not correctly handle multiple components & services, in XML format due to the way jackson nests the nodes

@gdgib-roche
Copy link
Author

Just added a unit test for serialization along with fixes to that too. FWIW, the previous code was semi-symmetrical across serialization & deserialization, it just also didn't work or generate/parse the expected XML. My sympathy to whoever had to understand the jackson internals enough to do this, I find them sometime frustratingly complex and I'm an expert on this kind of stuff.

@gdgib-roche
Copy link
Author

Will look into the failing workflow next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant